Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
| import org.wordpress.android.push.local.LocalPushScheduleWorker.Factory; | ||
| import org.wordpress.android.util.AppLog; | ||
| import org.wordpress.android.util.AppLog.T; | ||
| import org.wordpress.android.util.UploadWorker; |
There was a problem hiding this comment.
Reporter: CheckStyle
Rule: com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/debug/java/org/wordpress/android/WordPressDebug.java L17
Unused import - org.wordpress.android.util.UploadWorker.
|
|
||
| import org.wordpress.android.modules.DaggerAppComponentDebug; | ||
| import org.wordpress.android.push.local.LocalPushScheduleWorker; | ||
| import org.wordpress.android.push.local.LocalPushScheduleWorker.Factory; |
There was a problem hiding this comment.
Reporter: CheckStyle
Rule: com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/debug/java/org/wordpress/android/WordPressDebug.java L14
Unused import - org.wordpress.android.push.local.LocalPushScheduleWorker.Factory.
| import com.yarolegovich.wellsql.WellSql; | ||
|
|
||
| import org.wordpress.android.modules.DaggerAppComponentDebug; | ||
| import org.wordpress.android.push.local.LocalPushScheduleWorker; |
There was a problem hiding this comment.
Reporter: CheckStyle
Rule: com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/debug/java/org/wordpress/android/WordPressDebug.java L13
Unused import - org.wordpress.android.push.local.LocalPushScheduleWorker.
|
You can test the changes on this Pull Request by downloading the APK here. |
|
@ravishanker Before you start working on the missing functionality mentioned by @planarvoid, could you please split this into another PR with everything that we might want to reuse while working on other notifications? I'm thinking mainly of all the changes related to |
Fixes #14639
This draft contains partially completed "Create a site" notifications. The currently working version creates a notification in the main activity which is shown to the user without a site. What's missing is:
I think it's enough to do most of the changes in the
CreateSitePushScheduler. We also don't need to cancel the notifications since all of them are only shown if there are no sites connected to the account.To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.