Reverted materialVersion back to 1.2.1#14431
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
👋 @khaykov !
I have reviewed and tested this PR as per the instructions, everything works as expected, good fix! 🌟
While working in TimeZone selector we bumped material library version from 1.2.1 to 1.3.0.
Was bumping the material library a requirement for this work or was that an extra nice-to-have improvement? I am asking that because if that was a requirement I am not sure if I should be looking at a specific screen/feature to verify correctness with this revert. I did check the commit (2b085a6) that pumped the material library to 1.3.0, but I am still not 100% sure. Also, I am not sure whether bumping the core ktx is somehow related to that.
PS: Let me know your thoughts on the above. In the meanwhile, I will not merge this PR just yet.
|
Hey @ParaskP7 ! Thank you for the review! Regarding your question, it was nice to have improvement (We confirmed that there is no adverse effect on the original feature). I checked the change-log for material library, and it looked pretty innocent, so we went ahead with it. |
|
👋 @khaykov ! Perfect, I was thinking that, but played it safe and asked! 😅 Feel free to merge it with |
While working in TimeZone selector we bumped material library version from 1.2.1 to 1.3.0, and looks like this might have caused some issues (potentially related to new version of
ConstraintLayoutthat 1.3.0 is using).I only spotted the issue in reader, but it might appear somewhere else, so until we have more info on how to migrate to 1.3.0 I feel it's better to revert to 1.2.1
To test:
Post Cards should look like this:
And not like this:
PR submission checklist:
RELEASE-NOTES.txtif necessary.