Jetpack Section: Remove Jetpack Feature Flags by ParaskP7 · Pull Request #14409 · wordpress-mobile/WordPress-Android

ParaskP7 · 2021-04-06T12:50:40Z

This PR is responsible for removing all Jetpack Section related feature flags from the codebase. After that, the whole Jetpack Section grandparent related issue (see fixes) can be closed since those are the last items on its todo list.

To test:

Launch the app and go to My Site tab.
Test the Activity Log and Backup screens and more specifically make sure the Activity Log Filters are available and functional.
Test the Backup screen individually and more specifically make sure the screen is available and functional.
Test the Scan screen and more specifically make sure the screen is available and functional.
Test the Back Download screen and flows from within the Activity Log and Backup screens.
Test the Restore screen and flows from within the Activity Log and Backup screens.

Merge instructions:

Wait for confirmation from @leandroalonso before merging.
Wait for a 👍 from @malinajirka as well.

Regression Notes

Potential unintended areas of impact

N/A

What I did to test those areas of impact (or what existing automated tests I relied on)

N/A

What automated tests I added (or what prevented me from doing so)

N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Since it has been already two weeks after the release of the 'Jetpack Section' project, this feature flag can be now safely removed.

Since the restore available feature flag is now removed, this rewind dialog logic becomes unused and as such can be completely removed.

Since the restore available feature flag is now removed, this rewind click listener logic, which is associated with the show more menu, becomes unused and as such can be completely removed.

This field is unused and as such can be now safely removed.

This update removes 6 issues.

peril-wordpress-mobile · 2021-04-06T12:50:46Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2021-04-06T12:50:51Z

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

ParaskP7 · 2021-04-06T12:57:03Z

👋 @leandroalonso !

I want to bring this PR to your attention so as you can give the 🟢 light that we can now get rid of all the Jetpack Section related feature flags from our codebase. It has been some time since we release and it seems that now it is a good time to remove those. Wdyt?

PS: 👋 @malinajirka ! It would be great if we got your 👍 as well! 🙏

peril-wordpress-mobile · 2021-04-06T13:03:06Z

You can test the changes on this Pull Request by downloading the APK here.

malinajirka

Thanks for working on this @ParaskP7! I've scanned through the changes and they look good to me. Having said that I didn't do a full review, let me know if you'd prefer me to do a full review.

malinajirka · 2021-04-06T14:27:39Z

WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java

    }
-
-    // TODO: Inline this method when legacy MySiteFragment is removed
-    public static boolean isScanEnabled(boolean scanFeatureFlagEnabled, boolean scanPurchased, SiteModel site) {


❓ I'm wondering if we should wait with removal of this method until MySiteFragment gets replaced with the ImprovedMySiteFragment. Someone might not realize both of these fragment exist and update the condition in just one of them. Wdyt?

Good point @malinajirka. If you decide to change this @ParaskP7 , I can run through my tests again. Just let me know.

👋 Jirka!

Yeap, I was thinking about that too, I think it is better for me to revert that change, we already talked about that when that got introduced in the codebase. I just wanted to clean this up as well, but, it is better to be on the safe side for now.

PS: @zwarm , I'll do this tomorrow and let you know. 🙏

👋 @malinajirka @zwarm !

This is now done here: b7d3385

Thanks for making the change and it works as expected. 👍

zwarm

@ParaskP7 - All looks good. I tested the the Jetpack features including on the my_site_improvements_enabled flag. Thanks for the cleanup too!

Feel free to merge once you get the 👍 .

leandroalonso · 2021-04-06T16:29:32Z

@ParaskP7 🟢

Until the legacy 'MySiteFragment' class is removed, it is better if this utils method is used instead of duplicating the conditions in two separate places.

…id into issue/13267-remove-jetpack-feature-flags

ParaskP7 added 12 commits April 6, 2021 12:39

Build: Remove activity log filters feature flag

d620a3c

Since it has been already two weeks after the release of the 'Jetpack Section' project, this feature flag can be now safely removed.

Build: Remove backup screen available feature flag

3e9d7b2

Since it has been already two weeks after the release of the 'Jetpack Section' project, this feature flag can be now safely removed.

Build: Remove scan screen available feature flag

d844dae

Since it has been already two weeks after the release of the 'Jetpack Section' project, this feature flag can be now safely removed.

Build: Remove backup download available feature flag

1c78c85

Since it has been already two weeks after the release of the 'Jetpack Section' project, this feature flag can be now safely removed.

Build: Remove restore available feature flag

3a6d933

Since it has been already two weeks after the release of the 'Jetpack Section' project, this feature flag can be now safely removed.

Cleanup: Remove rewind dialog logic

b640d86

Since the restore available feature flag is now removed, this rewind dialog logic becomes unused and as such can be completely removed.

Cleanup: Remove rewind click listener logic

c154ea4

Since the restore available feature flag is now removed, this rewind click listener logic, which is associated with the show more menu, becomes unused and as such can be completely removed.

Analysis: Fix multi line if else issue on event item view holder

24d53bd

Cleanup: Remove progress bar visible activity log list item event field

b521298

This field is unused and as such can be now safely removed.

Cleanup: Remove formatted time activity log list item event field

ecf28cd

This field is unused and as such can be now safely removed.

Refactor: Add named arguments to all activity log list item event fields

c54c456

Analysis: Update detekt baseline

da788de

This update removes 6 issues.

ParaskP7 added [Type] Task Jetpack Mobile Jetpack App labels Apr 6, 2021

ParaskP7 added this to the 17.2 milestone Apr 6, 2021

ParaskP7 requested a review from zwarm April 6, 2021 12:50

ParaskP7 self-assigned this Apr 6, 2021

zwarm self-assigned this Apr 6, 2021

malinajirka reviewed Apr 6, 2021

View reviewed changes

zwarm approved these changes Apr 6, 2021

View reviewed changes

ParaskP7 added 2 commits April 7, 2021 10:51

Revert: Add back and use the is scan enabled utils method

b7d3385

Until the legacy 'MySiteFragment' class is removed, it is better if this utils method is used instead of duplicating the conditions in two separate places.

Merge branch 'develop' of github.com:wordpress-mobile/WordPress-Andro…

82b1629

…id into issue/13267-remove-jetpack-feature-flags

zwarm merged commit 2868476 into develop Apr 7, 2021

zwarm deleted the issue/13267-remove-jetpack-feature-flags branch April 7, 2021 12:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jetpack Section: Remove Jetpack Feature Flags#14409

Jetpack Section: Remove Jetpack Feature Flags#14409
zwarm merged 14 commits intodevelopfrom
issue/13267-remove-jetpack-feature-flags

ParaskP7 commented Apr 6, 2021 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented Apr 6, 2021 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented Apr 6, 2021

Uh oh!

ParaskP7 commented Apr 6, 2021

Uh oh!

peril-wordpress-mobile bot commented Apr 6, 2021 •

edited

Loading

Uh oh!

malinajirka left a comment

Uh oh!

malinajirka Apr 6, 2021

Uh oh!

zwarm Apr 6, 2021

Uh oh!

ParaskP7 Apr 6, 2021

Uh oh!

ParaskP7 Apr 7, 2021

Uh oh!

zwarm Apr 7, 2021

Uh oh!

zwarm left a comment

Uh oh!

leandroalonso commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ParaskP7 commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

peril-wordpress-mobile bot commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Apr 6, 2021

Uh oh!

ParaskP7 commented Apr 6, 2021

Uh oh!

peril-wordpress-mobile bot commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

malinajirka left a comment

Choose a reason for hiding this comment

Uh oh!

malinajirka Apr 6, 2021

Choose a reason for hiding this comment

Uh oh!

zwarm Apr 6, 2021

Choose a reason for hiding this comment

Uh oh!

ParaskP7 Apr 6, 2021

Choose a reason for hiding this comment

Uh oh!

ParaskP7 Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

zwarm Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

zwarm left a comment

Choose a reason for hiding this comment

Uh oh!

leandroalonso commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ParaskP7 commented Apr 6, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Apr 6, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Apr 6, 2021 •

edited

Loading