Save page info to PostRepository when creating a new page from Layout picker#14141
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
|
You can test the changes on this Pull Request by downloading the APK here. |
Generated by 🚫 dangerJS |
|
Note that this PR fixes one case of this issue: #13003, but I do not expect it to fix all cases (some Sentry events are for posts not pages). |
| mShortcutUtils.reportShortcutUsed(Shortcut.CREATE_NEW_POST); | ||
| } | ||
|
|
||
| private void newPageFromLayoutPickerSetup(String title, String content) { |
There was a problem hiding this comment.
We can probably reuse the implementation of newPostSetup since the only difference is the instantiatePostModel call.
This is just a suggestion and I understand that the way that it is implemented now might be more clear and easier to extend in the future.
antonis
left a comment
There was a problem hiding this comment.
Great work tracking down this issue and fixing it @cameronvoell 👍
I tested this on a Google Pixel 2 XL with Android 11 and works as expected. The code LGTM 🎉
I added only one comment but it is just a suggestion.
Fixes wordpress-mobile/gutenberg-mobile#2701
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.