Skip to content

Issue/14094 backup remove notify me#14098

Merged
ashiagr merged 11 commits intodevelopfrom
issue/14094-backup-remove-notify-me
Feb 18, 2021
Merged

Issue/14094 backup remove notify me#14098
ashiagr merged 11 commits intodevelopfrom
issue/14094-backup-remove-notify-me

Conversation

@zwarm
Copy link
Copy Markdown
Contributor

@zwarm zwarm commented Feb 17, 2021

Fixes #14094 (BackupDownload) and #14088 (restore)

This PR removes the "Let me know when you are finished!" buttons from the progress view within the Backup Download and Restore processes.

restore backup download
restore-light backup-download-light
restore backup download
restore-dark backup-download-dark

To test:
Restore Process

  • Launch the app
  • Navigate to Activity Log
  • Locate an activity log list item that can be restored
  • Tap menu -> Restore to this point
  • Tap Restore site
  • Tap confirm
  • Note
    • There is no longer a "Let me know when you are finished button"
    • The footnote is shown with the info icon to the left

Backup Download

  • Launch the app
  • Navigate to Activity Log
  • Locate an activity log list item that a downloadable backup file can be created
  • Tap menu -> Download backup
  • Tap Restore site
  • Tap confirm
  • Note
    • There is no longer a "Let me know when you are finished button"
    • The footnote is shown with the info icon to the left

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 16.8 milestone Feb 17, 2021
@zwarm zwarm requested review from a team and ashiagr and removed request for a team February 17, 2021 22:49
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 17, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 17, 2021

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr self-assigned this Feb 18, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 18, 2021

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

ashiagr
ashiagr approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zwarm! Everything looks great to me, notify me button is removed and footer text is shown with the icon. Also notify button click tracking events are removed.

Good job 👍.

@ashiagr ashiagr merged commit 3dcc561 into develop Feb 18, 2021
@ashiagr ashiagr deleted the issue/14094-backup-remove-notify-me branch February 18, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashiagr ashiagr ashiagr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

Labels

None yet

Projects

None yet

Milestone

16.8

Development

Successfully merging this pull request may close these issues.

Jetpack Backup Download: "Remove Let Me Know When Finished" Button

2 participants

@zwarm @ashiagr