Skip to content

Issue/13326 fix threat list item UI issue#14091

Merged
zwarm merged 2 commits intodevelopfrom
issue/13326-fix-ui-bug
Feb 19, 2021
Merged

Issue/13326 fix threat list item UI issue#14091
zwarm merged 2 commits intodevelopfrom
issue/13326-fix-ui-bug

Conversation

@ashiagr
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr commented Feb 17, 2021

This PR fixes a threat list item UI issue reported in #13994 (comment)).

To test:

  • Open Scan on a site with scan capability and with fixed or ignored threats (e.g. pressable-jetpack-daily-scan))
  • Click History menu, wait for history records to be displayed
  • Lock your phone, wait for 5'' secs, and unlock it
  • Notice that the threat list item is rendered properly

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

When screen is locked and unlocked, constraint layout group widget doesn't seem to respect the size assigned to it. Replacing it with a View resolves this issue.
@ashiagr ashiagr added this to the 16.8 milestone Feb 17, 2021
@ashiagr ashiagr requested a review from zwarm February 17, 2021 08:45
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ashiagr ashiagr mentioned this pull request Feb 17, 2021
67 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr modified the milestones: 16.8, 16.9 Feb 18, 2021
@zwarm zwarm self-assigned this Feb 19, 2021
Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiagr - Works like a charm, no more weirdness. 👍

@zwarm zwarm merged commit b8abb18 into develop Feb 19, 2021
@zwarm zwarm deleted the issue/13326-fix-ui-bug branch February 19, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants