Issue/13329 backup download notification#14075
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
34 tasks
malinajirka
approved these changes
Feb 16, 2021
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @zwarm! It's the best solution we can implement considering the current constraints. Good job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13329
This PR adds temporary support for Backup Download ready notifications.
Currently the notifications endpoint returns type=stat which is turned into a Stats deep link. This is not the correct behavior for the download notification. In this PR we intercept the note when it is returned from the API and swap type=stat with type=rewind-download-ready before it gets loaded into the database.
This code MUST be replaced once the API properly formats the Note (see issue #14074)
Notes
When viewing the notification detail view, the User name appears to be a link; however tapping on it will not take you anywhere. The type for this clickable range is marked as User; however User links are treated as if they are reader comment links and rely on siteId to be present in the node. In the case of backup download (and restore), the user node does not include siteId, so we can't forward the user anywhere (And I don't believe we should forward to the reader). Either way, it feels like the entire body response needs to be customized at the API level for both of these features. And we should identify where each link should forward too. Adding hacky workarounds is a poor solution.
Merge Instructions:
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.