Issue/13326 changes for fluxc scanstore suspend function#14010
Merged
Issue/13326 changes for fluxc scanstore suspend function#14010
Conversation
buildThreatsFixingStateItems accesses fluxc's getThreatModelByThreatId which is now a suspendable function.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Feb 9, 2021
Closed
|
You can test the changes on this Pull Request by downloading the APK here. |
zwarm
approved these changes
Feb 9, 2021
Contributor
zwarm
left a comment
There was a problem hiding this comment.
It looks good to me. I took scan out for a spin and didn't encounter any errors. Nice work.
Updated fluxC version to match latest tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13326
This PR adjusts code + tests to start using suspend functions from wordpress-mobile/WordPress-FluxC-Android#1866
To test:
There is no visual changes, make sure that CI runs tests without issues.
(Might also want to load scan screen to see nothing has broken)
Merge Instructions:
PR submission checklist:
RELEASE-NOTES.txtif necessary.