Skip to content

Jetpack Section: Update My Site Menu Items Strings#13982

Merged
ashiagr merged 2 commits intodevelopfrom
issue/13629-update-my-site-menu-items-strings
Feb 8, 2021
Merged

Jetpack Section: Update My Site Menu Items Strings#13982
ashiagr merged 2 commits intodevelopfrom
issue/13629-update-my-site-menu-items-strings

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Feb 5, 2021 •
edited
Loading

Parent #13629
Related #13969

This PR updates the following for the My Site screen menu items:

  • The Activity log string to Activity Log (title case).
  • The Jetpack settings string to Jetpack Settings (title case).

To test:

  • Launch the app and go to My Site tab.
  • Make sure that the above mentioned string changes are as described.
  • Go to My Site -> Toolbar Avatar -> App Settings -> Test feature configuration.
  • Enable MySiteImprovementsFeatureConfig, scroll down and click the RESTART THE APP button.
  • Make sure that the above mentioned string changes are as described.

Merge Instructions

  1. Make sure this PR has been reviewed by design.
  2. Remove the Needs Design Review label.
  3. Merge this PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7
Feature: Update my site menu item activity log string to title case
aac9e4a 
This commit actually remove the 'activity' string key altogether and
instead it reuses the already title cases 'activity_log' string key.
@ParaskP7
Feature: Update my site menu item jetpack settings to title case
8f82c5e
@ParaskP7 ParaskP7 added Jetpack [Status] Needs Design Review A designer needs to sign off on the implemented design. /My site Jetpack Mobile labels Feb 5, 2021
@ParaskP7 ParaskP7 added this to the 16.7 milestone Feb 5, 2021
@ParaskP7 ParaskP7 self-assigned this Feb 5, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

This was referenced Feb 5, 2021
Closed
Closed
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2021

You can test the changes on this Pull Request by downloading the APK here.

zwarm
zwarm approved these changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Feb 5, 2021

👋 @osullivanchris !

Let us know if you are okay with this change and we will then merge that to develop to get it be part of the next release (16.7).

👋 @zwarm !

Since I believe Chris will be probably okay with this change, as he requested those on #13969, please merge this PR by the end of your day (if it is still pending review by Chris), so that in ends up in the next release (16.7). I am pretty confident (99.9%) that Chris will be okay with it anyway. In any case we can make another change if need be and add it to the Beta release next sprint.

osullivanchris
osullivanchris approved these changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown

@osullivanchris osullivanchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @ParaskP7 !

@ashiagr
Copy link
Copy Markdown
Contributor

ashiagr commented Feb 8, 2021

Going ahead and merging this one to target 16.7!

@ashiagr ashiagr merged commit 6a19bd2 into develop Feb 8, 2021
@ashiagr ashiagr deleted the issue/13629-update-my-site-menu-items-strings branch February 8, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarm zwarm zwarm approved these changes

+1 more reviewer

@osullivanchris osullivanchris osullivanchris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ParaskP7 ParaskP7

Labels

Jetpack /My site [Status] Needs Design Review A designer needs to sign off on the implemented design.

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

4 participants

@ParaskP7 @ashiagr @zwarm @osullivanchris