Skip to content

Use firebase config to retrieve codeable url#13980

Merged
zwarm merged 1 commit intodevelopfrom
issue/13326-use-firebase-config-for-url
Feb 5, 2021
Merged

Use firebase config to retrieve codeable url#13980
zwarm merged 1 commit intodevelopfrom
issue/13326-use-firebase-config-for-url

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

Parent issue #13326

This PR uses firebase config to retrieve Codeable URL so we can update it in all apps version if needed.

To test:

  1. Select "pressable-jetpack-daily-scan"
  2. Open Scan
  3. Open History
  4. Switch to Ignored tab
  5. Open a threat
  6. Click on "Get free estimate" button and verify it redirects you to codeable.com

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.7 milestone Feb 5, 2021
@malinajirka malinajirka requested a review from zwarm February 5, 2021 15:58
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malinajirka LGTM! 👍

@zwarm zwarm merged commit 5469e74 into develop Feb 5, 2021
@zwarm zwarm deleted the issue/13326-use-firebase-config-for-url branch February 5, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants