Jetpack Section: Connect Activity Log Detail with Restore#13979
Merged
Jetpack Section: Connect Activity Log Detail with Restore#13979
Conversation
This new 'NavigationEvents' class will then help with navigating to the 'Restore' screen as well.
Also, this commit updates the already existing test to take into consideration the restore feature flag as well. These tests will fail as the implementation is not ready yet. The next commit will make the tests pass (TDD).
This commit makes the previous failing test pass (TDD).
This commit will make sure to forward the activity result from the restore flow to the activity log through the activity log detail screen. And, on the activity log screen the restore feature flag will differentiate between the corresponding navigation flows, the old and the new one.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13328
This PR connects the restore flow the activity log detail screen. This means that this PR makes sure that when a user presses the
RESTOREbutton within theActivity Log Detailscreen, then instead of getting aRewind Dialogthey get redirected to theRestorescreen and the new restore flow. Also, when a restore gets triggered from within the new restore flow, this PR makes sure that the user get redirected back to theActivity Logscreen, skipping theActivity Log Detailscreen and starts seeing the restore progress row within that screen.To test:
My Sitetab.Activity LogorBackupscreen,Activity Log Detailscreen.RESTOREbutton to launch theRestorescreen,Restore sitebutton. On the confirmation screen, click on theConfirm restore sitebutton.Ok, notify me!or navigate back manually (by clicking theXtoolbar button or pressing/swiping back).Activity Logscreen, skipping theActivity Log Detailscreen and a restore status will be triggered,Restorescreen and flows, go back.Activity Log Detailscreen.true, in order to test the old flow you will need to manually override the default tofalse.Rewind Dialogworks as well.PR submission checklist:
RELEASE-NOTES.txtif necessary.