Skip to content

Jetpack Section: Update FluxC for Activity Log Page Size#13975

Merged
ParaskP7 merged 2 commits intodevelopfrom
issue/13629-update-fluxc-for-activity-log-page-size
Feb 5, 2021
Merged

Jetpack Section: Update FluxC for Activity Log Page Size#13975
ParaskP7 merged 2 commits intodevelopfrom
issue/13629-update-fluxc-for-activity-log-page-size

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Feb 5, 2021

Parent #13629

This PR updates FluxC to that 'develop' version where ActivityLogStore.ACTIVITY_LOG_PAGE_SIZE is 100 (from previous 20). This step is required in order in order to avoid some of the scrolling issues on the 'Backups' screen due to the fact that the API enhancement is not ready yet.

To test:

  • Launch app and go to My Site tab.
  • Click on the Activity log menu item to launch the Activity Log screen.
  • Scroll to the bottom and verify that the pagination works as expected and that this time the page size is larger (100, from previous 20).
  • Go back and click on the Backup menu item to launch the Backup screen.
  • Again, scroll to the bottom and verify that the pagination works as expected and that this time the page size is larger (100, from previous 20).
  • If you previously encountered an issue with the Backup screen where there were no more items to load, due to the fact that the there were only a couple of rewindable items, thus not filling the available screen estate, verify that this problem is now gone or at least that it became less relevant.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This 'FluxC' tag updates FluxC to that 'develop' version where
'ActivityLogStore.ACTIVITY_LOG_PAGE_SIZE' is 100 (from 20).

This step is required in order in order to avoid some of the scrolling
issues on the 'Backups' screen due to the fact that the API enhancement
is not ready yet.
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ParaskP7 ParaskP7 mentioned this pull request Feb 5, 2021
40 tasks
@ParaskP7 ParaskP7 added this to the 16.7 milestone Feb 5, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2021

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Feb 5, 2021

👋 @malinajirka !

Someone already beat us to it and uploaded a newer version of FluxC, the 1.10.1-beta-6. 😄

As such, please just test this PR and I'll then silently close it afterwards.

Copy link
Copy Markdown
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ParaskP7! LGTM.

I'd personally still resolve the conflict (use beta-6) and merge this PR. Perhaps it's too much, but I prefer to keep the history as close to reality as possible. Anyway, up to you - I don't mind either way.

@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Feb 5, 2021

I'd personally still resolve the conflict (use beta-6) and merge this PR. Perhaps it's too much, but I prefer to keep the history as close to reality as possible. Anyway, up to you - I don't mind either way.

Actually, I would prefer that too. 😄 Cool, will definitely do that then! 🙏

@ParaskP7 ParaskP7 merged commit edd0c56 into develop Feb 5, 2021
@ParaskP7 ParaskP7 deleted the issue/13629-update-fluxc-for-activity-log-page-size branch February 5, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants