Jetpack Section: Update FluxC for Activity Log Page Size#13975
Jetpack Section: Update FluxC for Activity Log Page Size#13975
Conversation
This 'FluxC' tag updates FluxC to that 'develop' version where 'ActivityLogStore.ACTIVITY_LOG_PAGE_SIZE' is 100 (from 20). This step is required in order in order to avoid some of the scrolling issues on the 'Backups' screen due to the fact that the API enhancement is not ready yet.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
|
👋 @malinajirka ! Someone already beat us to it and uploaded a newer version of As such, please just test this PR and I'll then silently close it afterwards. |
There was a problem hiding this comment.
Thanks @ParaskP7! LGTM.
I'd personally still resolve the conflict (use beta-6) and merge this PR. Perhaps it's too much, but I prefer to keep the history as close to reality as possible. Anyway, up to you - I don't mind either way.
Actually, I would prefer that too. 😄 Cool, will definitely do that then! 🙏 |
Parent #13629
This PR updates
FluxCto that 'develop' version whereActivityLogStore.ACTIVITY_LOG_PAGE_SIZEis 100 (from previous 20). This step is required in order in order to avoid some of the scrolling issues on the 'Backups' screen due to the fact that the API enhancement is not ready yet.To test:
My Sitetab.Activity logmenu item to launch theActivity Logscreen.Backupmenu item to launch theBackupscreen.Backupscreen where there were no more items to load, due to the fact that the there were only a couple of rewindable items, thus not filling the available screen estate, verify that this problem is now gone or at least that it became less relevant.PR submission checklist:
RELEASE-NOTES.txtif necessary.