Issue/13328 13329 backup restore tracking#13947
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
ashiagr
left a comment
There was a problem hiding this comment.
👋 @zwarm, I saw all mentioned track events. I was wondering if we should include blog id with these events. Or is it sufficient that it gets logged when we open activity log?
Also (not related to this PR) I noticed this crash when I clicked notify me button in restore flow:
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at org.wordpress.android.ui.jetpack.restore.RestoreViewModel.onNotifyMeClick(RestoreViewModel.kt:494)
at org.wordpress.android.ui.jetpack.restore.RestoreViewModel.access$onNotifyMeClick(RestoreViewModel.kt:96)
at org.wordpress.android.ui.jetpack.restore.RestoreViewModel$buildProgress$1.invoke(RestoreViewModel.kt:215)
at org.wordpress.android.ui.jetpack.restore.RestoreViewModel$buildProgress$1.invoke(RestoreViewModel.kt:96)
at org.wordpress.android.ui.jetpack.common.viewholders.JetpackButtonViewHolder$updateState$1.onClick(JetpackButtonViewHolder.kt:39)
Regarding tracking errors, let's discuss and finalise them over Slack.
Excellent, I know what it is and will address today. I fixed the crash in 4378c75
👍 - yep, loving the "Draft" PR :) Thanks for the review. @ashiagr I had posted the q's in the sheet last night and Jirka answered there.
@ashiagr - I am moving this from a draft to a PR because it's good to go now. Thanks. |
Parent #13328 & 13329
This PR adds tracking to the backup download and restore flows.
Removing the DRAFT label - questions have been clarified
(1) Which errors should be tracked ** ONLY Errors that are shown to the user **
Missing/null parameters(2) Request types and escaped strings
JSON is good to send.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.