Issue/13326 scan fixing in builder#13940
Merged
malinajirka merged 25 commits intodevelopfrom Feb 4, 2021
Merged
Conversation
…eats state This helps showing fixing threat state when threat does not belong to the scan state model, e.g. when fixing an ignored threat.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
Generated by 🚫 dangerJS |
…re-to-help # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/builders/ScanStateListItemsBuilder.kt # WordPress/src/test/java/org/wordpress/android/ui/jetpack/scan/builders/ScanStateListItemsBuilderTest.kt
malinajirka
approved these changes
Feb 3, 2021
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Looks great @ashiagr, thanks!
WordPress/src/test/java/org/wordpress/android/ui/jetpack/scan/ScanViewModelTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/org/wordpress/android/ui/jetpack/scan/builders/ScanStateListItemsBuilderTest.kt
Outdated
Show resolved
Hide resolved
There's now a separate threats fixing state in the scan state builder class and tests for threats fixing state content items are added to builder test class.
Contributor
Author
|
Thanks for the review @malinajirka, ready for another look. |
Issue/13326 here to help
malinajirka
requested changes
Feb 4, 2021
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks for the improvements @ashiagr! I found one potential issue, let me know what you think ;).
...ss/src/main/java/org/wordpress/android/ui/jetpack/scan/builders/ScanStateListItemsBuilder.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13326
This PR moves threat fixing state item building logic to the builder class. It fixes the issue when progress bar was not displayed when an ignored threat was fixed.
It also
to have a bit of similarity with the iOS app.
threats_fixing.mov
To test
Prerequisite:
** Also test the flow when an ignored threat is fixed with steps from PR #13924.
Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.