Issue/13326 missing server credentials#13931
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
ashiagr
approved these changes
Feb 2, 2021
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
Works as expected, thank you for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue #13326
This PR fixes an issue where snackbar was not being shown when the server returned a response containing all threats in "NOT_FIXED" status. It also adds "invokedByUser" flag so the snackbar is shown only when the action is invoked by the user - it's not shown, when it's eg invoked by vm's "init()" method.
To test:
Prerequisites
PR submission checklist:
RELEASE-NOTES.txtif necessary.