Skip to content

Issue/13328 restore error retry#13930

Merged
ashiagr merged 6 commits intodevelopfrom
issue/13328-restore-error-retry
Feb 2, 2021
Merged

Issue/13328 restore error retry#13930
ashiagr merged 6 commits intodevelopfrom
issue/13328-restore-error-retry

Conversation

@zwarm
Copy link
Copy Markdown
Contributor

@zwarm zwarm commented Feb 1, 2021

Parent #13328

This PR updates GetRestoreStatusUseCase with the following:
(1) Reorders execution so that the Fetch from the server is first, then a get on the local db
(2) Enable 3 retries when error is received from server fetch
(3) Update tests in GetRestoreStatusUseCaseTest to account for delay

To test:

  • Launch the app
  • Ensure that the RestoreFeatureConfig flag is turned on
  • Navigate to Activity Log
  • Choose a activity item that is available for restore
  • Tap on the more menu
  • Tap on the Restore to this point menu option
  • Tap the Restore site button
  • Tap on confirm button
  • Let the process flow
  • Note that the progress view is working as expected

  • Launch the app
  • Ensure that the RestoreFeatureConfig flag is turned on
  • Navigate to Activity Log
  • Choose a activity item that is available for restore
  • Tap on the more menu
  • Tap on the Restore to this point menu option
  • Tap the Restore site button
  • Tap on confirm button
  • Tap the Let me know when finished! button to return to the activity log list
  • Note that the restore progress item is shown on the activity log

FYI @ParaskP7

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 16.7 milestone Feb 1, 2021
@zwarm zwarm requested review from a team and ashiagr and removed request for a team February 1, 2021 17:32
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 1, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request Feb 1, 2021
30 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 1, 2021

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr self-assigned this Feb 2, 2021
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested both the flows, works as described @zwarm!

@ashiagr ashiagr merged commit f3a57fc into develop Feb 2, 2021
@ashiagr ashiagr deleted the issue/13328-restore-error-retry branch February 2, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants