Issue/13326 support provisioning and invalid scan states#13923
Merged
Issue/13326 support provisioning and invalid scan states#13923
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
b642558 to
03f0114
Compare
ParaskP7
approved these changes
Feb 1, 2021
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @ashiagr !
I have reviewed and tested this PR as per the instruction, great job! Also, kudos for splitting the commit so nicely and for the very helpful test instruction! 🌟 🌟 🌟
I have left only one minor (🔍) test related comment. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply my only suggestion. However, feel free to ignore them and merge the PR yourself.
...rc/test/java/org/wordpress/android/ui/jetpack/scan/builders/ScanStateListItemsBuilderTest.kt
Show resolved
Hide resolved
…rt-missing-scan-states # Conflicts: # WordPress/src/test/java/org/wordpress/android/ui/jetpack/scan/ScanViewModelTest.kt
ParaskP7
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13326
This PR supports below scan states:
Provisioning(displays provisioning state items using Calypso's logic)UnAvailableandUnknown(displays full screen error)EDIT:
This PR also updates scanning state description for initial scan (Calypso's logic).
MostRecentStatus.isInitial = true)MostRecentStatus.isInitial = false)To test
Prerequisite:
You can test the changes in either ways:
ScanStateListItemsBuilderTestandScanViewModelTestor
PROVISIONINGStateUNKNOWNStateUNAVAILABLEStateSCANNINGStateMerge Instructions
PR submission checklist:
RELEASE-NOTES.txtif necessary.