Jetpack Section: Connect Restore with Activity Log/Backup Screen#13914
Merged
Jetpack Section: Connect Restore with Activity Log/Backup Screen#13914
Conversation
This is done for consistency purposes with 'RequestCodes.ACTIVITY_LOG_DETAIL'.
This is done for consistency purposes with 'RequestCodes.ACTIVITY_LOG_DETAIL'.
In addition to 'restoreId, this 'rewindId' is necessary in order to show the snackbar on the activity log/backup screen later on.
With this change the 'rewindId' and 'restoreId' are being passed from the 'RestoreFragment' to the 'ActivityLogListFragment', which in turn will trigger 'onQueryRestoreStatus(...)' on its view model layer.
These tests will fail as the implementation is not ready yet. The next commit will make the tests pass (TDD).
This commit makes the previous failing test pass (TDD).
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Jan 29, 2021
|
You can test the changes on this Pull Request by downloading the APK here. |
3 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13328
This PR connects the restore flow with the activity log/backup screens. This means that this PR makes sure that when a user presses the
Ok, notify me!button or presses/swipes back (triggering theonBackPressed()), while restore is in progress from within the restore screen, then a restore progress row appears on the activity log screen immediately. Before, a user would had to do a manual re-launch or pull-to-refresh on the activity log/backup screen to get the progress row appear.To test:
My Sitetab,My Site->Toolbar Avatar->App Settings->Test feature configuration.RestoreFeatureConfig, scroll down and click theRESTART THE APPbutton.Activity Logscreen,Restore to this pointto launch theRestorescreen,Restore sitebutton. On the confirmation screen, click on theConfirm restore sitebutton.Ok, notify me!or navigate back manually (by clicking theXtoolbar button or pressing/swiping back).Activity Logscreen and a restore status will be triggered,Activity Logscreen open both, within the app and the web (so you can see the actual progress),activityLogStore.fetchActivities(...)API call). In case the new restore item does not appear, wait a bit (maybe 10'' seconds) and trigger a manual pull-to-refresh. Verify that the new restore item appears after some time.PS: As always, I suggest doing a commit-by-commit review, from within the IDE, as this will make it much easier for you to review the overall solution. If you need to focus on the feature itself and not the refactor or tests filter the commits by
Featureto get a quick overall.PR submission checklist:
RELEASE-NOTES.txtif necessary.