Issue/13326 check fix threat status on init#13904
Merged
Conversation
…ls included error
…ll threats are fixed
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
…eck-fix-threat-status-on-init # Conflicts: # WordPress/src/test/java/org/wordpress/android/ui/jetpack/scan/ScanViewModelTest.kt
malinajirka
approved these changes
Jan 28, 2021
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @ashiagr! I found one issue but I don't think it's related to these changes.
Jetpack Threat Tester
I wasn't able to make this plugin work - even when I uncheck -> check the threats, the scan still won't find them. However, I tested the app with the calendar plugin. Any tips what I might be missing?
Potential issues
- Open Scan screen
- Quickly click on "Scan Now"
- Notice the scan starts and finishes within a few ms
- Quickly go back to My Site
- Open Scan screen again and notice there is a scan in progress
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/ScanViewModel.kt
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @malinajirka! I've added potential issue in the low priority tasks on the main issue. Merging this PR now. |
Base automatically changed from
issue/13326-start-scan-after-delay
to
develop
January 29, 2021 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13326
This PR fetches fix threats status for fixable threats (from scan state in db), and if found in fix in progress state, displays a progress bar on vm init.
It also
FetchFixThreatsState.NotStartedforFixStatus.NOT_STARTED7814b6cFixFailurestate is encountered only for a sublist of status models d294252, b187ebeTo test
Prerequisite:
Login to the app using above WP.com account and select the site on the My Site tab.
Click scan menu item on My Site.
Click fix threats button on scan screen.
Notice that fix threats progress bar is shown.
Return to My Site, re-enter Scan screen while threats are fixing.
Notice that fix threats progress bar is re-shown on scan screen.
Wait for fix to complete.
Notice that scan screen is refreshed with latest scan state.
Test covered in
FetchFixThreatsStatusUseCaseTest,ScanViewModelTest.Notes
pcdRpT-cM#comment-222are not yet covered in this PR.Merge Instructions
Make sure PR Issue/13326 start scan after delay #13903 is merged to develop- DoneRemove the "Not Ready for Merge label"- DonePR submission checklist:
RELEASE-NOTES.txtif necessary.