Skip to content

Issue/13629 show backup menu item#13882

Merged
zwarm merged 9 commits intodevelopfrom
issue/13629-show-backup-menu-item
Jan 26, 2021
Merged

Issue/13629 show backup menu item#13882
zwarm merged 9 commits intodevelopfrom
issue/13629-show-backup-menu-item

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

Partially fixes #13629

  • Shows/hides Backup screen menu item based on Jetpack capabilities
  • Extracts related logic into the JetpackCapabilitiesUseCase

To test:

  1. BackupScreenFeatureFlag = false, ScanScreenFeatureFlag = false, MySiteImprovementsFeatureFlag = false
  2. Verify both Backup and Scan menu items are hidden for all types of sites

  1. BackupScreenFeatureFlag = true, ScanScreenFeatureFlag = false, MySiteImprovementsFeatureFlag = false
  2. Verify Backup menu item is shown when the site has BACKUP/BACKUP_DAILY/BACKUP_REALTIME capability and it is not shown when it doesn't have any of the backup capabilities

  1. BackupScreenFeatureFlag = false, ScanScreenFeatureFlag = true, MySiteImprovementsFeatureFlag = false
  2. Verify Scan menu item is shown when the site has SCAN capability and it is not shown when it doesn't have it

  1. BackupScreenFeatureFlag = true, ScanScreenFeatureFlag = false, MySiteImprovementsFeatureFlag = true
  2. Verify Backup menu item is shown when the site has BACKUP/BACKUP_DAILY/BACKUP_REALTIME capability and it is not shown when it doesn't have any of the backup capabilities

  1. BackupScreenFeatureFlag = false, ScanScreenFeatureFlag = true, MySiteImprovementsFeatureFlag = true
  2. Verify Scan menu item is shown when the site has SCAN capability and it is not shown when it doesn't have it

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.7 milestone Jan 26, 2021
@malinajirka malinajirka requested review from a team and zwarm and removed request for a team January 26, 2021 09:06
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@zwarm zwarm self-assigned this Jan 26, 2021
Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malinajirka - Looks good. Tested all scenarios and they work as expected. 👍

@zwarm zwarm merged commit 19d6f42 into develop Jan 26, 2021
@zwarm zwarm deleted the issue/13629-show-backup-menu-item branch January 26, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetpack Section: Backup Screen

2 participants