Jetpack Section: Restore - Fix Dark Theme for Rewind Progress Row#13874
Merged
Jetpack Section: Restore - Fix Dark Theme for Rewind Progress Row#13874
Conversation
The main change here is the layout 'android:background' element which changes from the hardcoded '@android:color/white' color to the more dynamic and theme respected '?attr/selectableItemBackground' attribute.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
Hey! Bumping this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13328
This PR fixes an issue with the activity log rewind progress row UI now showing as should for dark theme.
To test:
My Sitetab.Activitymenu item to launch the activity log screen.RESTOREbutton. This will launch aRestore Sitedialog.RESTORE SITEconfirmation button. You will be automatically navigated back to theactivity logscreen.Restoring to Datarewind progress row is showing as expected for both dark and light theme.PS: As always, I suggest doing a commit-by-commit review as this will make it much easier for you to review the overall solution.
PR submission checklist:
RELEASE-NOTES.txtif necessary.