Skip to content

Scan History OnClick action#13856

Merged
malinajirka merged 4 commits intodevelopfrom
issue/13326-threat-detail-for-fixed-and-ignored
Jan 25, 2021
Merged

Scan History OnClick action#13856
malinajirka merged 4 commits intodevelopfrom
issue/13326-threat-detail-for-fixed-and-ignored

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka commented Jan 22, 2021

Parent issue #13326

Implements on list item click action on Scan History screen.

To test:

  1. Make sure Scan feature flag is enabled
  2. Open Scan
  3. Click on History action in the Toolbar
  4. Wait until the items get fetched (it might take 30+seconds)
  5. Click on one of the items and notice Threat Detail screen is shown

Note: Ignore all styling.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.7 milestone Jan 22, 2021
@malinajirka malinajirka requested a review from a team January 22, 2021 12:52
@malinajirka malinajirka self-assigned this Jan 22, 2021
@malinajirka malinajirka requested review from ashiagr and removed request for a team January 22, 2021 12:52
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 22, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 22, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@malinajirka malinajirka changed the title Issue/13326 threat detail for fixed and ignored Scan History OnClick action Jan 22, 2021
@ashiagr ashiagr self-assigned this Jan 25, 2021
ashiagr
ashiagr approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malinajirka! All looks good to me 👍.

Just noticed that Fix/ Ignore threat action when done from the scan history -> threat details screen, dismisses threat details screen but does not show scan screen with updated threats status.

This is not in the scope of this PR so adding it to the backlog.

Feel free to merge it after resolving the conflict.

@malinajirka malinajirka mentioned this pull request Jan 25, 2021
Closed
67 tasks
@malinajirka
Merge branch 'develop' into issue/13326-threat-detail-for-fixed-and-i…
0741283 
…gnored

# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryListFragment.kt
#	WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryListViewModel.kt
#	WordPress/src/test/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryListViewModelTest.kt
@malinajirka
Fix tests
37bde19
@malinajirka malinajirka merged commit 0cf4156 into develop Jan 25, 2021
@malinajirka malinajirka deleted the issue/13326-threat-detail-for-fixed-and-ignored branch January 25, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashiagr ashiagr ashiagr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

@malinajirka malinajirka

Labels

None yet

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

2 participants

@malinajirka @ashiagr