Issue/13326 fix threat from threat details#13825
Merged
malinajirka merged 12 commits intodevelopfrom Jan 20, 2021
Merged
Conversation
…reen This is done to remove the delay in the ThreatDetailsViewModel so the Snackbar message doesn't disappear right after we show it and before the navigation to scan state occurs. This delay wasn't sufficient for TalkBack, as for snackbar messages, when TalkBack is on, it is set to 10s.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
approved these changes
Jan 20, 2021
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @ashiagr! It looks good to me. Feel free to merge it after you consider the comment.
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/ScanFragment.kt
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @malinajirka! I've addressed the review comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13326
This PR
FixThreatsUsecasefor fix threat action on the threat details screen.fix_threat_web_success.mov
fix_threat_from_threat_details_mobile_success.mov
To test:
Prerequisite:
Repeat above steps and enable airplane mode after step 6. Notice that an error message is displayed and actions buttons are re-enabled.
Also test that when ignore threat action succeeds, ignore threat success message is shown on the scan state screen.
(Tests included in
ThreatDetailsViewModelTest,ScanViewModelTest)Notes:
PR submission checklist:
RELEASE-NOTES.txtif necessary.