Skip to content

Update subheader and icon for threats in fixed and ignored status#13824

Merged
ashiagr merged 11 commits intodevelopfrom
issue/13326-ignored-fixed-threat-status-ui
Jan 21, 2021
Merged

Update subheader and icon for threats in fixed and ignored status#13824
ashiagr merged 11 commits intodevelopfrom
issue/13326-ignored-fixed-threat-status-ui

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka commented Jan 20, 2021 •
edited
Loading

Parent issue #13326

This PR updates icon and subheader of Threat list items in Fixed and Ignored state.

I made two other changes

  1. Changed default ThreatStatus for dummy object used for testing to CURRENT
  2. Removed colors from related vector drawable resources and use tint to set the color programatically

Note: The UI is not polished, I made just necessary changes so the UI doesn't look completely broken (eg. vector dimensions).
Note2: Review by commits might be easier to follow.

To Test

  1. Open Scan
  2. Notice current threat has red background and "i"(notice) icon
  3. Open History
  4. Notice fixed threat has red background and shield icon with a checkmark
  5. Notice ignored threat has grey background and "i"(notice) icon

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.6 milestone Jan 20, 2021
@malinajirka malinajirka requested a review from a team January 20, 2021 11:29
@malinajirka malinajirka self-assigned this Jan 20, 2021
@malinajirka malinajirka requested review from ashiagr and removed request for a team January 20, 2021 11:29
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 20, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 20, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@malinajirka malinajirka force-pushed the issue/13326-ignored-fixed-threat-status-ui branch from 4bb4514 to 6c99851 Compare January 20, 2021 12:26
@malinajirka malinajirka mentioned this pull request Jan 20, 2021
Merged
3 tasks
@ashiagr ashiagr self-assigned this Jan 21, 2021
ashiagr
ashiagr approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @malinajirka! I just asked one question.
Also we'll need adjustments to sub header text color as per the latest mockups shared yesterday. We can take it up in another PR.

Approving this one. Feel free to merge it without any changes.

@malinajirka malinajirka requested a review from ashiagr January 21, 2021 08:14
ashiagr
ashiagr approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@ashiagr ashiagr merged commit 42d840a into develop Jan 21, 2021
@ashiagr ashiagr deleted the issue/13326-ignored-fixed-threat-status-ui branch January 21, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashiagr ashiagr ashiagr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

@malinajirka malinajirka

Labels

None yet

Projects

None yet

Milestone

16.6

Development

Successfully merging this pull request may close these issues.

2 participants

@malinajirka @ashiagr