Populate Scan History screen with data from /scan/history endpoint#13802
Merged
malinajirka merged 15 commits intodevelopfrom Jan 19, 2021
Merged
Populate Scan History screen with data from /scan/history endpoint#13802malinajirka merged 15 commits intodevelopfrom
malinajirka merged 15 commits intodevelopfrom
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
# Conflicts: # build.gradle
ashiagr
approved these changes
Jan 19, 2021
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
Thanks @malinajirka! So nice to start seeing threats history 🌟.
I just left minor comments. Feel free to address them in subsequent PR.
Approving this PR.
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryViewModel.kt
Show resolved
Hide resolved
...Press/src/main/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryListFragment.kt
Outdated
Show resolved
Hide resolved
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue #13326
Related PR in FluxC - wordpress-mobile/WordPress-FluxC-Android#1841
Merge instructions
This PR uses data provided by the /scan/history endpoint to populate Scan History screen (note: filtering by tab is not yet supported).
We decided to fetch data in the ScanHistoryViewModel (parent) and provide them to ScanHistoryListViewModel (children) through LiveData. Filtering is not yet supported, but I plan to do the actually filtering in the child view models.
To test:
Note:
PR submission checklist:
RELEASE-NOTES.txtif necessary.