Skip to content

Jetpack Section: Backup Screen - Rename Backup Feature Flags#13785

Merged
ParaskP7 merged 9 commits intodevelopfrom
issue/13629-rename-backup-feature-flags
Jan 18, 2021
Merged

Jetpack Section: Backup Screen - Rename Backup Feature Flags#13785
ParaskP7 merged 9 commits intodevelopfrom
issue/13629-rename-backup-feature-flags

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Jan 15, 2021 •
edited
Loading

Parent #13629

This PR mainly renames the Backup related feature flags. However, as part of this PR additional EXTRA changes were also made, see below:

  • Backup feature flag was changed to BackupDownload @zwarm
  • Backups feature flag was changed to BackupScreen @ParaskP7
  • EXTRA - Scan feature flag was change to ScanScreen @ashiagr
  • EXTRA - All above and the Restore feature flag were moved to the appropriate config package.

To test:

  • Launch app and go to My Site tab.
  • Go to My Site -> Toolbar Avatar -> App Settings -> Test feature configuration.
  • Verify all the related feature flags are updated according to the above description and below image.
  • Enable/Disable all the related feature flags and make sure they works as expected.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7 ParaskP7 added this to the 16.6 milestone Jan 15, 2021
@ParaskP7 ParaskP7 requested a review from ashiagr January 15, 2021 13:01
@ParaskP7 ParaskP7 self-assigned this Jan 15, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 15, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 15, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7 ParaskP7 mentioned this pull request Jan 15, 2021
Merged
3 tasks
@ashiagr ashiagr self-assigned this Jan 18, 2021
ashiagr
ashiagr approved these changes Jan 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ParaskP7! All looks good to me code-wise 👍. Also I've tested the feature flags and they work as expected.

Feel free to merge after resolving the conflict.

@ParaskP7
Merge branches 'develop' and 'issue/13629-rename-backup-feature-flags…
47ee772 
…' of github.com:wordpress-mobile/WordPress-Android into issue/13629-rename-backup-feature-flags

� Conflicts:
�	WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt
@ParaskP7 ParaskP7 merged commit 17efab6 into develop Jan 18, 2021
@ParaskP7 ParaskP7 deleted the issue/13629-rename-backup-feature-flags branch January 18, 2021 11:35
@ParaskP7 ParaskP7 changed the title Jetpack Mobile: Backup Screen - Rename Backup Feature Flags Jetpack Section: Backup Screen - Rename Backup Feature Flags Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashiagr ashiagr ashiagr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

@ParaskP7 ParaskP7

Labels

Jetpack [Type] Task

Projects

None yet

Milestone

16.6

Development

Successfully merging this pull request may close these issues.

2 participants

@ParaskP7 @ashiagr