Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
This was referenced Jan 14, 2021
ParaskP7
reviewed
Jan 15, 2021
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @zwarm !
I have reviewed and tested this PR as per the instruction, great job! Also, kudos for the Flow usage on the use case! 🌟 ❤️
I have left some comments (🔍 +
...ss/src/main/java/org/wordpress/android/ui/jetpack/backup/download/BackupDownloadViewModel.kt
Show resolved
Hide resolved
...s/src/main/java/org/wordpress/android/ui/jetpack/restore/usecases/GetRestoreStatusUseCase.kt
Show resolved
Hide resolved
...s/src/main/java/org/wordpress/android/ui/jetpack/restore/usecases/GetRestoreStatusUseCase.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/wordpress/android/ui/jetpack/restore/usecases/GetRestoreStatusUseCase.kt
Show resolved
Hide resolved
...s/src/main/java/org/wordpress/android/ui/jetpack/restore/usecases/GetRestoreStatusUseCase.kt
Outdated
Show resolved
Hide resolved
...g/wordpress/android/ui/jetpack/restore/viewholders/RestoreAdditionalInformationViewHolder.kt
Show resolved
Hide resolved
Contributor
Author
|
@ParaskP7 - Let me know what else needs to be done before you give you approval? Thanks. |
Contributor
ParaskP7
approved these changes
Jan 15, 2021
Contributor
Author
|
Many thanks @ParaskP7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13328
This PR implements the "progress" wizard step/view for the restore request and is mostly a clone of Backup Download progress with a few temporary navigations until the last step in the wizard has been implemented.
Merge Instructions
Cloned Classes
RestoreProgressAdapter
RestoreProgressFragment
RestoreProgressStateListItemBuilder
Notes:
To test:
Warning: The Restore site button is hooked up, so if you press it your site will be backed up!
Verify
PR submission checklist:
RELEASE-NOTES.txtif necessary.