Skip to content

Integrate gutenberg-mobile release 1.44.1#13777

Merged
cameronvoell merged 7 commits intorelease/16.5from
gutenberg/integrate_release_1.44.1
Jan 15, 2021
Merged

Integrate gutenberg-mobile release 1.44.1#13777
cameronvoell merged 7 commits intorelease/16.5from
gutenberg/integrate_release_1.44.1

Conversation

@cameronvoell
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell commented Jan 14, 2021

Description

This PR incorporates the 1.44.1 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3006

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 14, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 14, 2021

You can test the changes on this Pull Request by downloading the APK here.

@cameronvoell cameronvoell marked this pull request as ready for review January 14, 2021 19:24
Copy link
Copy Markdown
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the features being added with this beta fix are functioning as expected. Below are the steps, I followed.

Font Size


1. I created a post with a paragraph on Calypso.
2. I added a paragraph and set a custom font size so that a font size with the px value would be returned programmatically when
3. I can confirm that on my Google Pixel 4 XL with this build, I did not get a crash when I opened the post. I can also confirm that the paragraph was visible. 




Block Mover



1. I utilized the About page template to create a page that contains many blocks.
2. I can confirm that when I long pressed on the block at the bottom of the page I was given an option to move this block to the top. I can also confirm that the block was moved to the top when this option was triggered.

3. I then utilized this very block to test the movement to the bottom. After long pressing the block mover I saw the “Move to bottom” option. When I pressed it the block was then moved to the bottom of the page.

 


 
Questions

A separate question, I noticed that strings were added to the gb-mobile PR so I am just verifying, should those strings be included here or not?

@cameronvoell
Copy link
Copy Markdown
Contributor Author


A separate question, I noticed that strings were added to the gb-mobile PR so I am just verifying, should those strings be included here or not?

Nice catch, I updated the string here => 90121fc

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 15, 2021

Warnings
⚠️ PR is not assigned to a milestone.
⚠️

This PR contains changes to RELEASE_NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 dangerJS

Copy link
Copy Markdown
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the block mover behavior and the font size fix are contained within the built APK and I haven't noticed any other issues. LGTM 🚢

@cameronvoell cameronvoell merged commit 6fb5876 into release/16.5 Jan 15, 2021
@cameronvoell cameronvoell deleted the gutenberg/integrate_release_1.44.1 branch January 15, 2021 22:08
@loremattei loremattei mentioned this pull request Jan 18, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants