Skip to content

Issue/13326 init history view pager#13757

Merged
ashiagr merged 9 commits intodevelopfrom
issue/13326-init-history-view-pager
Jan 18, 2021
Merged

Issue/13326 init history view pager#13757
ashiagr merged 9 commits intodevelopfrom
issue/13326-init-history-view-pager

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka commented Jan 13, 2021

Parent issue #13326

This PR

  • Adds ScanHistoryListFragment: An instance per view pager tab will be used, ScanHistoryFragment will serve as parent of the ViewPager. I decided not to put the ViewPager into the Activity in order to keep the activity as simple as possible in case we decide to move to a single activity structure.
  • Moves Toolbar from ScanHistory Activity to ScanHistoryFragment: Same reasons as above
  • Adds ViewPager2 to ScanHistoryFragment
  • Adds "lift on scroll" (Z-axis) behavior. I tried adding show/hide on scroll behavior but it didn't work, I decided not to spent more time on it right now and add it later.

To test:

  1. Make sure Scan feature flag is enabled
  2. Make sure a site with Scan feature is selected
  3. Open Scan
  4. Click on "History" action in the toolbar
  5. Notice a viewpager with 3 tabs (3 ScanHistoryListFragments) is shown.
  6. Scroll down and notice the toolbar is lifted as you start scrolling (z-axis)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 13, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@malinajirka malinajirka mentioned this pull request Jan 13, 2021
67 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 13, 2021

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @malinajirka! Thank you for keeping activity as simple as possible 🙏.
I just left two minor comments and a question. Feel free to merge after considering them.

@malinajirka
Copy link
Copy Markdown
Contributor Author

Thanks for the review @ashiagr! I've implemented your suggestions - it's ready for another round 🙇 .

@malinajirka malinajirka requested a review from ashiagr January 18, 2021 12:09
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, all looks good to me 👍.

@ashiagr ashiagr merged commit 360689b into develop Jan 18, 2021
@ashiagr ashiagr deleted the issue/13326-init-history-view-pager branch January 18, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants