Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
31 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
👋 @malinajirka ! I am AFK tomorrow, but will be back the day after tomorrow. If you are in a rush to get this PR reviewed, feel free to re-assign it. 🙏 |
ashiagr
approved these changes
Jan 6, 2021
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
All events fired as described 👍.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue #13268
Adds analytics tracking to Activity Log filters.
To test
Selecting a date range
activitylog_filterbar_range_button_tappedis firedactivitylog_filterbar_select_rangeis fired withdistanceanddurationvaluesactivitylog_filterbar_reset_rangeis firedSelecting a single date
activitylog_filterbar_select_rangeis fired withdistanceanddurationvaluesactivitylog_filterbar_reset_rangeis firedSelecting activity type
activitylog_filterbar_type_button_tappedis firedactivitylog_filterbar_select_typeis fired with props about the selected groups, number of groups and total number of activitiesactivitylog_filterbar_reset_typeis firedClearing activity types
activitylog_filterbar_reset_typeis firedPR submission checklist:
RELEASE-NOTES.txtif necessary.