Skip to content

Activity log filter - tracking#13710

Merged
ashiagr merged 10 commits intodevelopfrom
issue/13268-tracking
Jan 6, 2021
Merged

Activity log filter - tracking#13710
ashiagr merged 10 commits intodevelopfrom
issue/13268-tracking

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka commented Jan 5, 2021

Parent issue #13268

Adds analytics tracking to Activity Log filters.

To test

Selecting a date range

  1. Open Activity Log
  2. Tap "Date Range"
  3. Check that activitylog_filterbar_range_button_tapped is fired
  4. Select a date range and tap Done
  5. Make sure activitylog_filterbar_select_range is fired with distance and duration values
  6. Tap clear button
  7. Make sure activitylog_filterbar_reset_range is fired

Selecting a single date

  1. Open Activity Log
  2. Tap "Date Range"
  3. Select a date range and tap Done
  4. Make sure activitylog_filterbar_select_range is fired with distance and duration values
  5. Open Date Range again
  6. Clear your selection
  7. Tap Done
  8. Make sure activitylog_filterbar_reset_range is fired

Selecting activity type

  1. Open Activity Log
  2. Tap "Activity Type"
  3. Make sure activitylog_filterbar_type_button_tapped is fired
  4. Select one or more activity types and tap done
  5. Make sure activitylog_filterbar_select_type is fired with props about the selected groups, number of groups and total number of activities
  6. Tap clear button
  7. Make sure activitylog_filterbar_reset_type is fired

Clearing activity types

  1. Open Activity Log
  2. Tap "Activity Type"
  3. Select one activity type and tap done
  4. Verify the label on the chip has the following format "User (15)"
  5. Tap "Activity Type" again
  6. Clear your selection and tap done
  7. Make sure activitylog_filterbar_reset_type is fired

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 5, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@malinajirka malinajirka mentioned this pull request Jan 5, 2021
31 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7
Copy link
Copy Markdown
Contributor

ParaskP7 commented Jan 5, 2021

👋 @malinajirka !

I am AFK tomorrow, but will be back the day after tomorrow. If you are in a rush to get this PR reviewed, feel free to re-assign it.

🙏

@malinajirka malinajirka requested review from ashiagr and removed request for ParaskP7 January 6, 2021 07:23
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All events fired as described 👍.

@ashiagr ashiagr merged commit 102262f into develop Jan 6, 2021
@ashiagr ashiagr deleted the issue/13268-tracking branch January 6, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants