Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
31 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
ashiagr
approved these changes
Dec 23, 2020
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
Great job @malinajirka! All issues fixed and tests passed 👏.
Issue 1 ✅
Issue 2 ✅
Issue 3 ✅
Thank you once again for fixing these tricky issues!
WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/utils/DateUtils.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue #13268
This PR fixes a few issues related to DateRange filtering in Activity Log
Merge instructions:
Issue 1
DateRange provided by the MaterialDateRangePicker is in GMT+0. However, the user wants to see data for dateRange in their timezone not in UTC. This issue is fixed in FluxC - more info on this PR.
Fixed in 92876fd
Issue 2
Label on the dateRange filter chip was being formatted using device timezone. However, MaterialDateRangePicker is using GMT+0. This lead to an issue when device timezone was
GMT-N. For example when the user selected "Nov 10-12th" in "GMT-7", the label was "Nov 9 - 11".This issue is fixed in caa13cf
Issue 3
When user selected any date range, the end date was set to start of the day instead of end of the day. This lead to multiple issues. For example selecting date range for a single day "Nov 10-10" would never show any data, since the range had duration equal to 0seconds.
Fixed in 214cc2d
To test:
Issue 2)a) Timezone is GMT+0 (contains
+00:00) (this change was not necessary but I decided to stay consistent with calypso)b) Date range is taking into account user timezone (it's 7 hours from midnight since we are using GMT-7) (
Issue 1)c)
before(range end) parameter is selected date plus 23h 59m 59s?page=1&number=10&after=2020-12-10T07:00:00+00:00&before=2020-12-13T06:59:59+00:00&_locale=en_USPR submission checklist:
RELEASE-NOTES.txtif necessary.