Skip to content

Jetpack Mobile: Scan - Create skeleton vm, fragment, test#13527

Merged
ashiagr merged 7 commits intodevelopfrom
issue/13326-scan-skeleton
Dec 7, 2020
Merged

Jetpack Mobile: Scan - Create skeleton vm, fragment, test#13527
ashiagr merged 7 commits intodevelopfrom
issue/13326-scan-skeleton

Conversation

@ashiagr
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr commented Dec 3, 2020 •
edited
Loading

Parent #13326

This PR creates skeleton vm, fragment, test for the Scan screen.

To test - make sure the Scan feature flag is on in App settings.

  • Click Scan on My Site
  • Notice that blank Scan screen is shown with a back arrow
  • Clicking back arrow should return to My Site

Note: Also linked Scan screen with Scan menu on improved My Site (accessible when both Scan feature flag and MySiteImprovements flag are set to on in App settings).

Visibility of Scan menu based on a site is not covered in this PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 16.4 milestone Dec 3, 2020
@ashiagr ashiagr requested review from malinajirka and zwarm December 3, 2020 06:03
@ashiagr ashiagr self-assigned this Dec 3, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 3, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 3, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr requested review from malinajirka and zwarm December 3, 2020 07:15
@zwarm zwarm self-assigned this Dec 4, 2020
zwarm
zwarm approved these changes Dec 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Scan view is launched on tap.
@ashiagr - Feel free to merge when conflict is resolved.

@ashiagr
Merge branch 'develop' into issue/13326-scan-skeleton
64682b8 
# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/ui/mysite/ImprovedMySiteFragment.kt
@ashiagr ashiagr mentioned this pull request Dec 7, 2020
Closed
67 tasks
@ashiagr ashiagr merged commit c2282c0 into develop Dec 7, 2020
@ashiagr ashiagr deleted the issue/13326-scan-skeleton branch December 7, 2020 06:56
@ashiagr ashiagr changed the title Scan: Create skeleton vm, fragment, test Jetpack Section: Scan - Create skeleton vm, fragment, test Dec 7, 2020
@malinajirka malinajirka mentioned this pull request Dec 7, 2020
Merged
3 tasks
@ashiagr ashiagr changed the title Jetpack Section: Scan - Create skeleton vm, fragment, test Jetpack Mobile: Scan - Create skeleton vm, fragment, test Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarm zwarm zwarm approved these changes

@malinajirka malinajirka Awaiting requested review from malinajirka

Assignees

@zwarm zwarm

@ashiagr ashiagr

Labels

None yet

Projects

None yet

Milestone

16.4

Development

Successfully merging this pull request may close these issues.

2 participants

@ashiagr @zwarm