Skip to content

Issue/13509 fix check box clicks#13511

Merged
zwarm merged 18 commits intodevelopfrom
issue/13509-fix-check-box-clicks
Dec 1, 2020
Merged

Issue/13509 fix check box clicks#13511
zwarm merged 18 commits intodevelopfrom
issue/13509-fix-check-box-clicks

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

Fixes #13509

To test:

  1. Launch App
  2. Set up the Activity Log Filters feature flag
  3. Navigate to ActivityLog
  4. Tap on the ActivityType chip
  5. Tap on the checkbox proper - not the row - select mutliples
  6. Tap clear
  7. Notice that the checkboxes are cleared
  8. Tap on the checkbox proper - not the row - select mutliples
  9. Tap on Apply
  10. Tap on the ActivityType chip
  11. Notice that previously selected items are checked

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@malinajirka malinajirka modified the milestones: 16.5, 16.4 Dec 1, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🎉
Tapping on Checkbox itself, then clearing works good and the values are persisted on device rotation and on apply.

@zwarm zwarm merged commit 29f8114 into develop Dec 1, 2020
@zwarm zwarm deleted the issue/13509-fix-check-box-clicks branch December 1, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActivityLog - ActivityType clear not clearing checkbox selections

2 participants