Issue/13268 activity type filter screen skeleton#13420
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
3 tasks
ParaskP7
reviewed
Nov 23, 2020
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
Good job @malinajirka and nice commits! 🌟
Thanks for including me in this PR! 🙏
Only minor and questions from my side (as always)!
...c/main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterAdapter.kt
Outdated
Show resolved
Hide resolved
.../main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterFragment.kt
Outdated
Show resolved
Hide resolved
.../main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterFragment.kt
Outdated
Show resolved
Hide resolved
.../main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterFragment.kt
Show resolved
Hide resolved
WordPress/src/main/res/layout/activity_log_type_filter_fragment.xml
Outdated
Show resolved
Hide resolved
WordPress/src/main/res/layout/activity_log_type_filter_item.xml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ParaskP7 Thanks so much for the review and great tips! |
Contributor
|
OMG @malinajirka , you are the Mr. Speedy Gonzales indeed, thank you so much for taking care of all that! ❤️ |
ashiagr
approved these changes
Nov 23, 2020
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
Thanks both of you! All looks good to me 👍.
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #13268
This PR updates Activity type filter screen
Note: The adapter doesn't contain any data so the screen is completely empty (except of the "X" button)
To test - make sure the ActivityLogFilters feature flag is on in App settings
PR submission checklist:
RELEASE-NOTES.txtif necessary.