Add FLAG_UPDATE_CURRENT flag to notification pending intent#13171
Merged
Add FLAG_UPDATE_CURRENT flag to notification pending intent#13171
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
mchowning
approved these changes
Oct 19, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Looks good to me. I tried to recreate the crash, but I wasn't able to either. Your fix makes sense and seems to be working well in my testing.
I'm very curious to see if this does fix the crash since this seems like a particularly nasty bit of behavior by Android.
Contributor
Author
|
If it doesn't work, we can look into replacing |
This was referenced Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8363
It seems that this issue happens because the pending intent sometimes doesn't pass the extras. It seems that the system (because of efficiency) reuses the previous pending intent without the extras (the issue).
The suggested fix seems to be to use the
PendingIntent.FLAG_UPDATE_CURRENTflag when creating the pending intent.The second fix in this PR is a proper error message when the
SiteModelis null in thePostsListActivityTo test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.