Skip to content

Remove the overlay from the Unsupported Block Editor web view, if Login with WordPress.com is requested.#12994

Merged
marecar3 merged 2 commits intogutenberg/integrate_release_1.37.1from
gutenberg/ube-fix-overlay
Sep 19, 2020
Merged

Remove the overlay from the Unsupported Block Editor web view, if Login with WordPress.com is requested.#12994
marecar3 merged 2 commits intogutenberg/integrate_release_1.37.1from
gutenberg/ube-fix-overlay

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Sep 18, 2020

This PR implements the changes to remove the overlay from the Unsupported Block Editor web view, if Login with WordPress.com is requested.

To test:

  • On a Jetpack connected site, have a post with an unsupported block.
  • On web, check that SSO is enabled under Settings -> Security. (Allow users to log in to this site using WordPress.com accounts)
  • Delete WPiOS from the device and install it from this PR.
  • Open the post with the unsupported block on the Jetpack connected site.
  • Open the Unsupported Block Editor for the unsupported block.
  • Check that the overlay disappear to show the Login With WordPress.com screen.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 added this to the 15.8 milestone Sep 18, 2020
@marecar3 marecar3 self-assigned this Sep 18, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

cameronvoell
cameronvoell approved these changes Sep 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue, thanks @marecar3 !

@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Sep 19, 2020 •
edited
Loading

Fixes the issue, thanks @marecar3 !

Thank you @cameronvoell for finding this one!

@marecar3 marecar3 merged commit 25cda76 into gutenberg/integrate_release_1.37.1 Sep 19, 2020
@marecar3 marecar3 deleted the gutenberg/ube-fix-overlay branch September 19, 2020 00:41
This was referenced Sep 19, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cameronvoell cameronvoell cameronvoell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marecar3 marecar3

Labels

None yet

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

2 participants

@marecar3 @cameronvoell