Skip to content

Safe cast site model in PhotoPickerFragment.kt#12804

Merged
oguzkocer merged 3 commits intorelease/15.5.1from
fix/safe-cast-site-model-in-photo-picker-fragment
Aug 26, 2020
Merged

Safe cast site model in PhotoPickerFragment.kt#12804
oguzkocer merged 3 commits intorelease/15.5.1from
fix/safe-cast-site-model-in-photo-picker-fragment

Conversation

@planarvoid
Copy link
Copy Markdown
Contributor

@planarvoid planarvoid commented Aug 26, 2020 •
edited
Loading

Fixes: #12696

This crash is caused by not safe casting SiteModel which could be nullable.

Steps to reproduce:

  • Start with a clean install
  • Create a new account
  • On the signup confirmation click on Add Avatar
  • The app crashes

To test:

  • Start with a clean install
  • Create a new account
  • On the signup confirmation click on Add Avatar
  • The app doesn't crash

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@planarvoid planarvoid self-assigned this Aug 26, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 26, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 26, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 26, 2020

You can test the changes on this Pull Request by downloading the APK here.

@oguzkocer oguzkocer changed the base branch from release/15.5 to release/15.5.1 August 26, 2020 09:00
@oguzkocer oguzkocer changed the base branch from release/15.5.1 to release/15.5 August 26, 2020 09:05
@oguzkocer oguzkocer changed the base branch from release/15.5 to release/15.5.1 August 26, 2020 09:05
oguzkocer
oguzkocer approved these changes Aug 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a hotfix branch for this and updated the PR. Github is refusing to show the correct diff even though the only change is the efc9a5f. I'll merge once CircleCI is ✅ and proceed with the hotfix.

@develric
Copy link
Copy Markdown
Contributor

develric commented Aug 26, 2020

Just adding I also cross-checked this: following test steps was able to reproduce the issue and checked the fix worked.

@oguzkocer oguzkocer merged commit b426c31 into release/15.5.1 Aug 26, 2020
@oguzkocer oguzkocer deleted the fix/safe-cast-site-model-in-photo-picker-fragment branch August 26, 2020 09:18
@oguzkocer oguzkocer mentioned this pull request Aug 26, 2020
Closed
@renanferrari renanferrari mentioned this pull request Sep 2, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oguzkocer oguzkocer oguzkocer approved these changes

@loremattei loremattei Awaiting requested review from loremattei

@develric develric Awaiting requested review from develric

Assignees

@planarvoid planarvoid

Labels

[Type] Crash

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@planarvoid @develric @oguzkocer