Enable editing of unsupported blocks#12331
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
6 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
Author
Test resultsSelf-hosted site: nervous-crane.jurassic.ninja✅ Editing an unsupported block works fine. Jetpack connected site: reluctant-kestrel.jurassic.ninja✅ There is no option to edit unsupported blocks on Jetpack connected self-hosted sites, as expected. WP.com site: pschrottkyubp.wordpress.com✅ Editing an unsupported block works fine. |
marecar3
approved these changes
Jul 1, 2020
Contributor
marecar3
left a comment
There was a problem hiding this comment.
LGTM! Works as expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related wordpress-mobile/gutenberg-mobile#2457
To test: See WordPress/gutenberg#23592
PR submission checklist:
RELEASE-NOTES.txtif necessary.