Skip to content

[Gutenberg] Fix gutenberg web-view auth issues with Atomic sites #12222

Merged
marecar3 merged 1 commit intodevelopfrom
fix/error_while_loading_atomic_site_on_unsupported_block
Jun 19, 2020
Merged

[Gutenberg] Fix gutenberg web-view auth issues with Atomic sites #12222
marecar3 merged 1 commit intodevelopfrom
fix/error_while_loading_atomic_site_on_unsupported_block

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Jun 18, 2020 •
edited
Loading

Fixes # wordpress-mobile/gutenberg-mobile#2063 (comment)

To test:

  • Setup an atomic site and test as public and private.
  • Create a post with a block not yet supported on mobile.
  • Test on a real device.
  • Will need Metro server running (on gutenberg-mobile develop branch is enough)
  • Log out from your wp account in the app to clean cookies.
  • Uninstall the app from your device.
  • Install building the app from this PR.
  • Login and go directly to the Atomic site.
  • Open the created post with unsupported block.
  • Open the unsupported block on the web view.
  • Check that gutenberg opens on the web view without asking for credentials 🙏

@guarani could you please test this as you already did with WPiOS which experience can be used in this review?

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 added the Gutenberg Editing and display of Gutenberg blocks. label Jun 18, 2020
@marecar3 marecar3 added this to the 15.2 milestone Jun 18, 2020
@marecar3 marecar3 requested review from guarani and khaykov June 18, 2020 15:59
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 18, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 18, 2020

You can test the changes on this Pull Request by downloading the APK here.

guarani
guarani approved these changes Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & working great @marecar3!

I followed the test steps above, starting from a clean emulator (wipe data) for each of these below scenarios.

  • Existing Atomic site, not launched but private, unsupported blocks in a draft post
  • Same Atomic site, now public, using the same post (now published instead of draft)
  • Regular WP.com site, not yet launched, unsupported blocks in a draft post
  • Regular WP.com site, now launched (public), using the same post (now published instead of draft)

@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Jun 19, 2020

Tested & working great @marecar3!

I followed the test steps above, starting from a clean emulator (wipe data) for each of these below scenarios.

  • Existing Atomic site, not launched but private, unsupported blocks in a draft post
  • Same Atomic site, now public, using the same post (now published instead of draft)
  • Regular WP.com site, not yet launched, unsupported blocks in a draft post
  • Regular WP.com site, now launched (public), using the same post (now published instead of draft)

Thanks @guarani 🙇

@marecar3 marecar3 merged commit ce1fbd6 into develop Jun 19, 2020
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Jun 19, 2020

Fixes parts of wordpress-mobile/gutenberg-mobile#2358

Thank you @marecar3 !

@marecar3 marecar3 mentioned this pull request Jun 23, 2020
Merged
3 tasks
@SergioEstevao SergioEstevao self-assigned this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaykov khaykov Awaiting requested review from khaykov

1 more reviewer

@guarani guarani guarani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SergioEstevao SergioEstevao

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

15.2

Development

Successfully merging this pull request may close these issues.

4 participants

@marecar3 @etoledom @guarani @SergioEstevao