Skip to content

[Gutenberg] Add stub result to Gutenberg Glue Class#12121

Merged
chipsnyder merged 1 commit intodevelopfrom
rnmobile/issue/1744-themeColor-unblock
Jun 8, 2020
Merged

[Gutenberg] Add stub result to Gutenberg Glue Class#12121
chipsnyder merged 1 commit intodevelopfrom
rnmobile/issue/1744-themeColor-unblock

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Jun 7, 2020

To test:

  • Open the editor Gutenberg Editor and expect to see the same default colors.

Note: This is meant to unblock develop while #12041 finishes its review process.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added this to the 15.1 milestone Jun 7, 2020
@chipsnyder chipsnyder requested review from marecar3 and mkevins June 7, 2020 20:46
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 7, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@chipsnyder chipsnyder mentioned this pull request Jun 7, 2020
Merged
3 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 7, 2020

You can test the changes on this Pull Request by downloading the APK here.

mkevins
mkevins approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via described steps and confirmed this PR addresses the incompatibility. Approving proactively, in case this PR is needed.

@chipsnyder chipsnyder marked this pull request as ready for review June 8, 2020 12:03
@chipsnyder chipsnyder merged commit f433f38 into develop Jun 8, 2020
@chipsnyder chipsnyder deleted the rnmobile/issue/1744-themeColor-unblock branch June 8, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marecar3 marecar3 Awaiting requested review from marecar3

1 more reviewer

@mkevins mkevins mkevins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15.1

Development

Successfully merging this pull request may close these issues.

2 participants

@chipsnyder @mkevins