Skip to content

Pulling avoid-jitpack changes into gutenberg release branch#11893

Merged
mchowning merged 1 commit intogutenberg/integrate_release_1.28.0from
gutenberg/pull_avoid_jitpack_changes_into_release_branch
May 12, 2020
Merged

Pulling avoid-jitpack changes into gutenberg release branch#11893
mchowning merged 1 commit intogutenberg/integrate_release_1.28.0from
gutenberg/pull_avoid_jitpack_changes_into_release_branch

Conversation

@mchowning
Copy link
Copy Markdown
Contributor

@mchowning mchowning commented May 11, 2020 •
edited
Loading

Pulling changes to build gutenberg-mobile locally without JitPack from the release/14.8 branch into the gutenberg/integrate_release_1.28.0 so that branch can successfully build on CI.

To test:

Build debug and release builds locally with BUILD_GUTENBERG_FROM_SOURCE set to false. Also verify that debug builds can be built with BUILD_GUTENBERG_FROM_SOURCE set to true (so 3 combinations total).

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest @mchowning
Merge pull request #11833 from wordpress-mobile/gutenberg/embedded-bu…
22c6ff1 
…ild-no-jitpack

Build gutenberg-mobile locally without JitPack
@mchowning mchowning added this to the 14.9 milestone May 11, 2020
@mchowning mchowning self-assigned this May 11, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 11, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 11, 2020

You can test the changes on this Pull Request by downloading the APK here.

@mchowning mchowning removed their assignment May 11, 2020
@mchowning mchowning marked this pull request as ready for review May 11, 2020 22:15
@mchowning mchowning mentioned this pull request May 11, 2020
Merged
3 tasks
@pinarol pinarol mentioned this pull request May 12, 2020
Merged
5 tasks
@cameronvoell
Copy link
Copy Markdown
Contributor

cameronvoell commented May 12, 2020

Tested as of first commit - 22c6ff1
BUILD_GUTENBERG_FROM_SOURCE set to false:

  • ./gradlew assembleVanillaDebug - SUCCESS
  • ./gradlew assembleVanillaRelease - SUCCESS

BUILD_GUTENBERG_FROM_SOURCE set to true:

  • ./gradlew assembleVanillaDebug - FAIL
  • ./gradlew assembleVanillaRelease - FAIL

Error when set to true is below. Note that I seem to have to run yarn install in the gutenberg-mobile directory between builds, and I also am attempting to run gradle assemble with clean, --no-build-cache, --rerun-tasks options (./gradlew clean assembleVanillaDebug --no-build-cache --rerun-tasks)

Log:

Task :react-native-gutenberg-bridge:copyJSBundle
Done copying the Android JS bundle to assets folder
Task :react-native-gutenberg-bridge:backupHermesReleaseAAR
Done backing up Hermes release AARs
Task :react-native-gutenberg-bridge:backupHermesDebugAAR
Done backing up Hermes debug AARs
Task :react-native-gutenberg-bridge:javaPreCompileDebug FAILED
FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ‘:react-native-gutenberg-bridge:javaPreCompileDebug’.

Could not resolve all files for configuration ‘:react-native-gutenberg-bridge:debugCompileClasspath’.
Failed to transform file ‘hermes-debug.aar’ to match attributes {artifactType=android-classes, org.gradle.usage=java-api}
Execution failed for JetifyTransform: /Users/cameronvoell/A8C/DEVELOP/WordPress-Android/libs/gutenberg-mobile/node_modules/hermes-engine/android/hermes-debug.aar.
> Failed to transform ‘/Users/cameronvoell/A8C/DEVELOP/WordPress-Android/libs/gutenberg-mobile/node_modules/hermes-engine/android/hermes-debug.aar’ using Jetifier. Reason: Cannot open a library at ‘FileMapping(from=/Users/cameronvoell/A8C/DEVELOP/WordPress-Android/libs/gutenberg-mobile/node_modules/hermes-engine/android/hermes-debug.aar, to=/Users/cameronvoell/.gradle/caches/transforms-2/files-2.1/1f0307359cb81998a1a5e69fb065dea2/jetified-hermes-debug.aar)’. (Run with --stacktrace for more details.)

@chipsnyder
Copy link
Copy Markdown
Contributor

chipsnyder commented May 12, 2020

BUILD_GUTENBERG_FROM_SOURCE set to false:

  • ./gradlew assembleVanillaDebug - SUCCESS
  • ./gradlew assembleVanillaRelease - SUCCESS

BUILD_GUTENBERG_FROM_SOURCE set to true:

  • ./gradlew assembleVanillaDebug - SUCCESS
  • ./gradlew assembleVanillaRelease - FAIL- same error as @cameronvoell
  • ./gradlew assembleWasabiDebug - FAIL- same error as @cameronvoell

chipsnyder
chipsnyder approved these changes May 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few things to iron out but as discussed in a side chat building from source isn't crucial for the release and we'll iron it out in another PR.

@mchowning mchowning merged commit cff0791 into gutenberg/integrate_release_1.28.0 May 12, 2020
@mchowning mchowning deleted the gutenberg/pull_avoid_jitpack_changes_into_release_branch branch May 12, 2020 19:07
@mchowning mchowning mentioned this pull request May 13, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@marecar3 marecar3 Awaiting requested review from marecar3

1 more reviewer

@chipsnyder chipsnyder chipsnyder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

14.9

Development

Successfully merging this pull request may close these issues.

4 participants

@mchowning @cameronvoell @chipsnyder @hypest