When upgrading from older version do not go through migration script steps.#11885
Merged
malinajirka merged 1 commit intodevelopfrom May 12, 2020
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
approved these changes
May 12, 2020
Contributor
There was a problem hiding this comment.
Thanks @khaykov !
I tried to update from 10.1 -> develop and the app crashed.
Then, I tried to udpate from 10.1 -> issue/11845-fix-reader-db-update-script and the app didn't crash.
I also tried to update from 10.1 -> develop and the app crashed -> then I updated to issue/11845-fix-reader-db-update-script and it fixed the issue.
So I can confirm these changes work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11845
This PR fixes the migration script for reader DB. When we encounter a migration attempt from the version before the migration scripts were introduced, we recreate the tables, and skip the individual migration steps.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.