Issue/11633 material placeholders#11678
Merged
planarvoid merged 5 commits intodevelopfrom Apr 29, 2020
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
Hi there! P.S: I am still working on the messaging for these bumps, so please let me know if you have any questions/concerns/feedback. |
planarvoid
approved these changes
Apr 29, 2020
Contributor
planarvoid
left a comment
There was a problem hiding this comment.
The changes look great 👍
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11633
This PR updates the color of image placeholders, so they will look good in both light and dark themes.
They should look more like this:
And not like this:
To test:
I recommend downgrading network speed of your emulator and visiting following places:
Placeholders are used in a variety of places, but those are the main ones.
Technical note:
It's really hard to get themed attributes to work with Glide (and in general) on API 21-23. Because of this, we have to use regular color with alpha value baked in. This is gross, but can't be helped until we drop the support for API 21-23.
PR submission checklist:
RELEASE-NOTES.txtif necessary.