Update media insertion to send caption information.#11670
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
2 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
maxme
reviewed
Apr 17, 2020
Contributor
maxme
left a comment
There was a problem hiding this comment.
LGTM
Works fine: https://bia.is/s/jHnd/screencast-Genymotion-2020-04-17_17.33.04.252.webm
Waiting for the PR in the gutenberg repo to be merged.
# Conflicts: # libs/gutenberg-mobile
maxme
approved these changes
Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the block editor Insert captions when selecting a media item of the media library that has a caption defined.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.