Merged
Conversation
wpmobilebot
reviewed
Mar 30, 2020
...src/test/java/org/wordpress/android/ui/stats/refresh/lists/detail/PostDayViewsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
wpmobilebot
reviewed
Mar 30, 2020
...src/test/java/org/wordpress/android/ui/stats/refresh/lists/detail/PostDayViewsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
|
You can test the changes on this Pull Request by downloading the APK here. |
develric
approved these changes
Mar 31, 2020
Contributor
develric
left a comment
There was a problem hiding this comment.
Hi @planarvoid , tested with Pixel 3 Emu API 29; code looks good and works as described 👍 ! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11546
We haven't been properly checking whether the model is empty. What we were receiving from the backend is a list of items (years, months) with value 0 instead of an empty list. This PR introduces a check to properly see if models are empty.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.