Skip to content

Fix QuickStart dialog configuration change issue#11419

Merged
khaykov merged 1 commit intodevelopfrom
issue-10845/quick_start_configuration_change
Mar 10, 2020
Merged

Fix QuickStart dialog configuration change issue#11419
khaykov merged 1 commit intodevelopfrom
issue-10845/quick_start_configuration_change

Conversation

@jd-alexander
Copy link
Copy Markdown
Contributor

@jd-alexander jd-alexander commented Mar 10, 2020

Fixes #10845

Findings

The FullScreenDialogFragments being used to communicate with the MySiteFragment to confirmation clicks. When a configuration change takes place, the fragment loses reference to the parent fragment.

Solution

To reattach the listeners on all fragments within the MySiteFragment that are of the type FullScreenDialogFragment

Testing

  1. Click on "Customize your site" or "Grow your audience" section of the QuickStart
  2. Rotate your device
  3. Click on one of the items (eg. View Site)
  4. Notice that the actions work similarly to how they did before the configuration change.

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • I have considered adding accessibility improvements for my changes.
  • If it's feasible, I have added unit tests.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Mar 10, 2020

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander jd-alexander marked this pull request as ready for review March 10, 2020 15:09
@jd-alexander jd-alexander requested a review from khaykov March 10, 2020 15:10
@khaykov khaykov self-assigned this Mar 10, 2020
Copy link
Copy Markdown
Contributor

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jd-alexander ! I confirmed the issue and that the fix works.

@khaykov khaykov merged commit e7f1453 into develop Mar 10, 2020
@khaykov khaykov deleted the issue-10845/quick_start_configuration_change branch March 10, 2020 22:19
@jd-alexander
Copy link
Copy Markdown
Contributor Author

Thanks for the review @khaykov 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QuickStart dialog configuration change

2 participants