Fix QuickStart dialog configuration change issue#11419
Merged
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
khaykov
approved these changes
Mar 10, 2020
Contributor
khaykov
left a comment
There was a problem hiding this comment.
Thanks for the fix @jd-alexander ! I confirmed the issue and that the fix works.
Contributor
Author
|
Thanks for the review @khaykov 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10845
Findings
The
FullScreenDialogFragments being used to communicate with theMySiteFragmentto confirmation clicks. When a configuration change takes place, the fragment loses reference to the parent fragment.Solution
To reattach the listeners on all fragments within the
MySiteFragmentthat are of the typeFullScreenDialogFragmentTesting
Reviewing
Only 1 reviewer is needed but anyone can review.
Submitter Checklist
RELEASE-NOTES.txtif necessary.