Add unit tests for UploadUtils getErrorMessageResId by malinajirka · Pull Request #11379 · wordpress-mobile/WordPress-Android

malinajirka · 2020-02-25T15:59:41Z

Fixes #11285

Adds unit tests for UploadUtils.getErrorMessageResIdFromPostError method.

To test:

This PR doesn't need to be manually tested.

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2020-02-25T16:02:31Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and published post eligible for auto upload`() {
+        verifyGenericError(false, PUBLISHED,true, R.string.error_post_not_published_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L92
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:33Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and published page eligible for auto upload`() {
+        verifyGenericError(true,  PUBLISHED,true, R.string.error_page_not_published_retrying)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L97
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:34Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and published page eligible for auto upload`() {
+        verifyGenericError(true,  PUBLISHED,true, R.string.error_page_not_published_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L97
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:35Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and private post eligible for auto upload`() {
+        verifyGenericError(false, PRIVATE,true, R.string.error_post_not_published_retrying_private)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L102
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:36Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and private page eligible for auto upload`() {
+        verifyGenericError(true,  PRIVATE,true, R.string.error_page_not_published_retrying_private)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L107
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:37Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and private page eligible for auto upload`() {
+        verifyGenericError(true,  PRIVATE,true, R.string.error_page_not_published_retrying_private)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L107
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:38Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and DRAFT post eligible for auto upload`() {
+        verifyGenericError(false, DRAFT,true, R.string.error_generic_error_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L112
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:39Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and DRAFT page eligible for auto upload`() {
+        verifyGenericError(true,  DRAFT,true, R.string.error_generic_error_retrying)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L117
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:40Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and DRAFT page eligible for auto upload`() {
+        verifyGenericError(true,  DRAFT,true, R.string.error_generic_error_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L117
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:41Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and SCHEDULED post eligible for auto upload`() {
+        verifyGenericError(false, SCHEDULED,true, R.string.error_post_not_scheduled_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L122
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:42Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and SCHEDULED page eligible for auto upload`() {
+        verifyGenericError(true,  SCHEDULED,true, R.string.error_page_not_scheduled_retrying)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L127
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:43Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and SCHEDULED page eligible for auto upload`() {
+        verifyGenericError(true,  SCHEDULED,true, R.string.error_page_not_scheduled_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L127
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:44Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and PENDING post eligible for auto upload`() {
+        verifyGenericError(false, PENDING,true, R.string.error_post_not_submitted_retrying)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L132
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:45Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and published post NOT eligible for auto upload`() {
+        verifyGenericError(false, PUBLISHED,false, R.string.error_post_not_published)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L142
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:46Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and published page NOT eligible for auto upload`() {
+        verifyGenericError(true,  PUBLISHED,false, R.string.error_page_not_published)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L147
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:47Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and published page NOT eligible for auto upload`() {
+        verifyGenericError(true,  PUBLISHED,false, R.string.error_page_not_published)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L147
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:49Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and private post NOT eligible for auto upload`() {
+        verifyGenericError(false, PRIVATE,false, R.string.error_post_not_published_private)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L152
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:50Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and private page NOT eligible for auto upload`() {
+        verifyGenericError(true,  PRIVATE,false, R.string.error_page_not_published_private)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L157
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:51Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and private page NOT eligible for auto upload`() {
+        verifyGenericError(true,  PRIVATE,false, R.string.error_page_not_published_private)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L157
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:52Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and DRAFT post NOT eligible for auto upload`() {
+        verifyGenericError(false, DRAFT,false, R.string.error_generic_error)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L162
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:53Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and DRAFT page NOT eligible for auto upload`() {
+        verifyGenericError(true,  DRAFT,false, R.string.error_generic_error)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L167
Unnecessary space(s)

wpmobilebot · 2020-02-25T16:02:54Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and DRAFT page NOT eligible for auto upload`() {
+        verifyGenericError(true,  DRAFT,false, R.string.error_generic_error)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L167
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:55Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and SCHEDULED post NOT eligible for auto upload`() {
+        verifyGenericError(false, SCHEDULED,false, R.string.error_post_not_scheduled)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L172
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:56Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and SCHEDULED page NOT eligible for auto upload`() {
+        verifyGenericError(true,  SCHEDULED,false, R.string.error_page_not_scheduled)


Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L177
Unnecessary space(s)

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

wpmobilebot · 2020-02-25T16:02:58Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+
+    @Test
+    fun `getErrorMessageResIdFromPostError on generic error and PENDING post NOT eligible for auto upload`() {
+        verifyGenericError(false, PENDING,false, R.string.error_post_not_submitted)


Reporter: Checkstyle
Rule: comma-spacing
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L182
Missing spacing after ","

wpmobilebot · 2020-02-25T16:02:59Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+        verifyGenericError(true, PENDING, false, R.string.error_page_not_submitted)
+    }
+
+    private fun verifyGenericError(isPage: Boolean, postStatus: PostStatus, isEligibleForAutoUpload: Boolean, resId: Int) {


Reporter: Checkstyle
Rule: parameter-list-wrapping
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L190
Parameter should be on a separate line (unless all parameters can fit a single line)

wpmobilebot · 2020-02-25T16:03:00Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+        verifyGenericError(true, PENDING, false, R.string.error_page_not_submitted)
+    }
+
+    private fun verifyGenericError(isPage: Boolean, postStatus: PostStatus, isEligibleForAutoUpload: Boolean, resId: Int) {


Reporter: Checkstyle
Rule: parameter-list-wrapping
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L190
Parameter should be on a separate line (unless all parameters can fit a single line)

wpmobilebot · 2020-02-25T16:03:01Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+        verifyGenericError(true, PENDING, false, R.string.error_page_not_submitted)
+    }
+
+    private fun verifyGenericError(isPage: Boolean, postStatus: PostStatus, isEligibleForAutoUpload: Boolean, resId: Int) {


Reporter: Checkstyle
Rule: parameter-list-wrapping
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L190
Parameter should be on a separate line (unless all parameters can fit a single line)

wpmobilebot · 2020-02-25T16:03:03Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+        verifyGenericError(true, PENDING, false, R.string.error_page_not_submitted)
+    }
+
+    private fun verifyGenericError(isPage: Boolean, postStatus: PostStatus, isEligibleForAutoUpload: Boolean, resId: Int) {


Reporter: Checkstyle
Rule: parameter-list-wrapping
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L190
Parameter should be on a separate line (unless all parameters can fit a single line)

wpmobilebot · 2020-02-25T16:03:04Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+        verifyGenericError(true, PENDING, false, R.string.error_page_not_submitted)
+    }
+
+    private fun verifyGenericError(isPage: Boolean, postStatus: PostStatus, isEligibleForAutoUpload: Boolean, resId: Int) {


Reporter: Checkstyle
Rule: parameter-list-wrapping
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L190
Missing newline before ")"

wpmobilebot · 2020-02-25T16:03:04Z

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt

+        verifyGenericError(true, PENDING, false, R.string.error_page_not_submitted)
+    }
+
+    private fun verifyGenericError(isPage: Boolean, postStatus: PostStatus, isEligibleForAutoUpload: Boolean, resId: Int) {


Reporter: Checkstyle
Rule: max-line-length
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt L190
Exceeded max line length (120) (cannot be auto-corrected)

peril-wordpress-mobile · 2020-02-25T16:05:27Z

You can test the changes on this Pull Request by downloading the APK here.

jd-alexander

Great work @malinajirka! Love the use of the verifyGenericError function so that the code isn't duplicated. LGTM 🚢

Add unit tests for UploadUtils getErrorMessageResId

74c8d43

malinajirka added Post List Posts + Pages Testing labels Feb 25, 2020

malinajirka added this to the 14.4 milestone Feb 25, 2020

malinajirka requested a review from jd-alexander February 25, 2020 15:59

wpmobilebot reviewed Feb 25, 2020

View reviewed changes

WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadUtilsTest.kt Outdated Show resolved Hide resolved

wpmobilebot reviewed Feb 25, 2020

View reviewed changes

Refactor UploadUtils unit tests

48bff39

jd-alexander approved these changes Feb 25, 2020

View reviewed changes

jd-alexander merged commit 4d8f6db into feature/master-pages-offline-support Feb 25, 2020

jd-alexander deleted the issue/11285-test-upload-utils-post-msgs branch February 25, 2020 21:11

malinajirka modified the milestones: 14.4 ❄️, 14.6 Mar 23, 2020

Conversation

malinajirka commented Feb 25, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peril-wordpress-mobile bot commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jd-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

peril-wordpress-mobile bot commented Feb 25, 2020 •

edited

Loading