Skip to content

Fixed issue with sharing external media/links from other apps#11121

Merged
marecar3 merged 12 commits intodevelopfrom
gutenberg/10570-Sharing-external-media_links-from-another-app-will-not-work-if-the-block-editor-is-enabled
Jan 31, 2020
Merged

Fixed issue with sharing external media/links from other apps#11121
marecar3 merged 12 commits intodevelopfrom
gutenberg/10570-Sharing-external-media_links-from-another-app-will-not-work-if-the-block-editor-is-enabled

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Jan 21, 2020 •
edited
Loading

Fixes #10570

Following gb-mobile PR: wordpress-mobile/gutenberg-mobile#1817

To test:

Test sharing media (Image/Video)

  1. Make sure that default Editor is Gutenberg
  2. Go to Photos and Videos
  3. Find proper image/video
  4. Click on the share button and choose WPAndroid
  5. WPAndroid will open and image/video should be uploaded with success

Test sharing link from Web Browser in Gutenberg

  1. Make sure that default Editor is Gutenberg
  2. Open some Web Browser
  3. Visit random url
  4. Click on the share button and choose WPAndroid
  5. WPAndroid will open and the title with a clickable link from Web Browser should be in the Post.

Test sharing link from Web Browser in Aztec

  1. Make sure that default Editor is Aztec
  2. Open some Web Browser
  3. Visit random url
  4. Click on the share button and choose WPAndroid
  5. WPAndroid will open and the title with a clickable link from Web Browser should be in the Post.

Test sharing link from other apps (Youtube, Twitter...) in Gutenberg

  1. Make sure that default Editor is Gutenberg
  2. Open another app (Youtube, Twitter...)
  3. Pick some video/Twitter post ....
  4. Click on the share button and choose WPAndroid
  5. WPAndroid will open with a link in the Post.

Test sharing link from other apps (Youtube, Twitter...) in Aztec

  1. Make sure that default Editor is Aztec
  2. Open another app (Youtube, Twitter...)
  3. Pick some video/Twitter post ....
  4. Click on the share button and choose WPAndroid
  5. WPAndroid will open with a link in the Post.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 21, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@marecar3 marecar3 added this to the 14.1 milestone Jan 22, 2020
@marecar3 marecar3 changed the title Fixed issue with missing content shared from web broswer Fixed issue with sharing external media links Jan 22, 2020
@marecar3 marecar3 requested a review from chipsnyder January 24, 2020 15:08
wpmobilebot
wpmobilebot reviewed Jan 24, 2020
View reviewed changes
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java Outdated
}

private String migrateToGutenbergEditor(String content) {
return "<!-- wp:paragraph --><p>" + content + "</p><!-- /wp:paragraph -->";;
Copy link
Copy Markdown
Contributor

@wpmobilebot wpmobilebot Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: Checkstyle
Rule: com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java L2027
Empty statement.

@marecar3 marecar3 changed the title Fixed issue with sharing external media links Fixed issue with sharing external media/links from other apps Jan 24, 2020
@marecar3 marecar3 requested a review from mkevins January 24, 2020 15:16
@marecar3 marecar3 mentioned this pull request Jan 24, 2020
Merged
2 tasks
@marecar3 marecar3 marked this pull request as ready for review January 24, 2020 15:48
chipsnyder
chipsnyder approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested on my Pixel 3a 👍

One thing that I noticed while testing sharing media was the button above "Add to new post" didn't have any text. This issue seems separate from this change but wanted to know if you knew off hand what it should say?

@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Jan 27, 2020

LGTM tested on my Pixel 3a 👍

One thing that I noticed while testing sharing media was the button above "Add to new post" didn't have any text. This issue seems separate from this change but wanted to know if you knew off hand what it should say?

Thanks for the review @chipsnyder !
That's an interesting problem. I didn't experience it. Maybe we can raise an issue about that?

@chipsnyder chipsnyder mentioned this pull request Jan 27, 2020
Closed
@chipsnyder
Copy link
Copy Markdown
Contributor

chipsnyder commented Jan 27, 2020

Opened the issue at #11173

@maxme maxme modified the milestones: 14.1, 14.2 Jan 27, 2020
@mrfoxtalbot
Copy link
Copy Markdown

mrfoxtalbot commented Jan 28, 2020

This may already be fixed with this merge, and/or it may merit opening a separate issue, but I have noticed that sharing from Simplenote is still not working either, with the block editor enabled.

@marecar3
Merge branch 'develop' into gutenberg/10570-Sharing-external-media_li…
46676cb 
…nks-from-another-app-will-not-work-if-the-block-editor-is-enabled
@marecar3
Update gb-mobile ref
550eafc
@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Jan 28, 2020

This may already be fixed with this merge, and/or it may merit opening a separate issue, but I have noticed that sharing from Simplenote is still not working either, with the block editor enabled.

Hey @mrfoxtalbot , I have tested this PR against Simplenote and it's working for me.
Thanks for pointing on that one.

@malinajirka malinajirka mentioned this pull request Jan 30, 2020
Closed
@marecar3
Merge branch 'develop' into gutenberg/10570-Sharing-external-media_li…
947a05e 
…nks-from-another-app-will-not-work-if-the-block-editor-is-enabled

# Conflicts:
#	libs/gutenberg-mobile
@marecar3
Merge branch 'develop' into gutenberg/10570-Sharing-external-media_li…
1c59c32 
…nks-from-another-app-will-not-work-if-the-block-editor-is-enabled
@marecar3
Update gb-mobile reference
ec1fcf9
@marecar3 marecar3 merged commit 33e8778 into develop Jan 31, 2020
@marecar3 marecar3 deleted the gutenberg/10570-Sharing-external-media_links-from-another-app-will-not-work-if-the-block-editor-is-enabled branch January 31, 2020 11:25
@maxme
Copy link
Copy Markdown
Contributor

maxme commented Jan 31, 2020

Thank you @marecar3, @chipsnyder and @mrfoxtalbot - I'm glad this one is fixed!

@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Jan 31, 2020

Thanks, @maxme !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpmobilebot wpmobilebot wpmobilebot left review comments

@maxme maxme Awaiting requested review from maxme

+1 more reviewer

@chipsnyder chipsnyder chipsnyder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

14.2

Development

Successfully merging this pull request may close these issues.

Blank post trying to share media/links from another app when block editor enabled

5 participants

@marecar3 @chipsnyder @mrfoxtalbot @maxme @wpmobilebot