Fix #10747: Gutenberg rollout phase 2#11029
Merged
Conversation
…how a second popup
|
You can test the changes on this Pull Request by downloading the APK here. |
2 tasks
Contributor
|
Removed the PR from the project board since we typically only track tickets on the board. |
2 tasks
hypest
reviewed
Jan 7, 2020
WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefs.java
Outdated
Show resolved
Hide resolved
hypest
reviewed
Jan 7, 2020
WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Ready for a second round. When this is merged, #11062 will need a review. |
hypest
reviewed
Jan 9, 2020
WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefs.java
Outdated
Show resolved
Hide resolved
hypest
reviewed
Jan 9, 2020
hypest
reviewed
Jan 9, 2020
Contributor
hypest
left a comment
There was a problem hiding this comment.
Finished my pass @maxme and looks good, only one comment is pending at this point:#11029 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10747
This FluxC PR must be merged first: wordpress-mobile/WordPress-FluxC-Android#1466✅ FluxC version was bumped to 1.5.6 in 7c586eaThis PR adds:
We made big improvements to the block editor and think it\'s worth a try! We enabled it for new posts and pages but if you'd like to change to the classic editor, go to 'My Site' > 'Site Settings'Note: there is one downside to this, if the user wasn't part of the first rollout (it means they switched manually to Gutenberg a while ago) and they switch a site to Aztec, the next time they re-open the app this site will be switched back to Gutenberg (this will happen only once, they'll be considered in the rollout group after that).
To test:
GB_ROLLOUT_PERCENTAGE_PHASE_2to 100% and build.