Update gutenberg-mobile to use the Hermes JS runtime#10997
Merged
hypest merged 20 commits intogutenberg/after-1.21.0from Jan 24, 2020
Merged
Update gutenberg-mobile to use the Hermes JS runtime#10997hypest merged 20 commits intogutenberg/after-1.21.0from
hypest merged 20 commits intogutenberg/after-1.21.0from
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
1 task
marecar3
approved these changes
Jan 23, 2020
Contributor
marecar3
left a comment
There was a problem hiding this comment.
Nice work here!
LGTM! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointing to gutenberg mobile with RN version 0.61.5, including changing the JS runtime from JSC to Hermes.
Changes in this PR:
releaseversion of Hermes is available in runtime. The debug version of Hermes is still available depending on the build type.To test:
The block editor should work as normal, maybe with a slight improvement in its speed performance.
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.